Fixes #45 - training queue waiting times #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0repwn3r
requested changes
Apr 24, 2024
|
I think for the purposes of the training queue, maxing out at days is more helpful, as waiting lists in some divisions can last over a year. For ATC staff trying to see how quickly a waiting list is moving, seeing several students waiting for "1 year" isn't particularly useful, whereas seeing the exact number of days allows this kind of analysis without needing to export data from Hayya's database. I have added a new parameter to the relativeTime function which allows specification of a maximum unit, so allows flexibility where the function is used in other areas. I have maxed it out at "days" on the training queues and "hours" on the online users view. |
|
Ok.. that sounds good to me. |
c0repwn3r
previously approved these changes
Apr 29, 2024
|
I’ll disable codestyle for this PR- give me a second |
xkeels
force-pushed
the
keels/hay-121-training-queue-waiting-time-showing-as-unknown-when-greater
branch
from
3e96dd0 to
c9b65d6
Compare
…owing-as-unknown-when-greater
c0repwn3r
approved these changes
May 21, 2024
c0repwn3r
deleted the
keels/hay-121-training-queue-waiting-time-showing-as-unknown-when-greater
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45. Behaviour was caused by relativeTime function returning "Unknown" if the number of days was greater than the maximum (30 days). This PR sets the maximum to Infinity. Having the function return "weeks", "months" or "years" seems less helpful for list tracking purposes.