Merge pull request #21 from SmartColumbusOS/fix_memory

Properly setting memory config values for hive metastore
UrbanOS-Public · May 10, 2019 · 319d10e · 319d10e
2 parents aea5667 + 5d130d3
commit 319d10e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/charts/templates/metastore/deployment.yaml b/charts/templates/metastore/deployment.yaml
@@ -60,9 +60,9 @@ spec:
         - name: HADOOP_OPTS
           value: >
             -server
-            -Xmx{{ .Values.presto.jvm.maxHeapSize }}
-            -XX:+{{ .Values.presto.jvm.gcMethod.type }}
-            -XX:G1HeapRegionSize={{ .Values.presto.jvm.gcMethod.g1.heapRegionSize }}
+            -Xmx{{ .Values.metastore.jvm.maxHeapSize }}
+            -XX:+{{ .Values.metastore.jvm.gcMethod.type }}
+            -XX:G1HeapRegionSize={{ .Values.metastore.jvm.gcMethod.g1.heapRegionSize }}
             -XX:+UseGCOverheadLimit
             -XX:+ExplicitGCInvokesConcurrent
             -XX:+HeapDumpOnOutOfMemoryError

diff --git a/charts/values.yaml b/charts/values.yaml
@@ -40,6 +40,12 @@ presto:
       alb.ingress.kubernetes.io/healthcheck-path: /v1/cluster
 
 metastore:
+  jvm:
+    maxHeapSize: 768M
+    gcMethod:
+      type: UseG1GC
+      g1:
+        heapRegionSize: 32M
   allowDropTable: false
   service:
     type: ClusterIP

diff --git a/images/metastore/Dockerfile b/images/metastore/Dockerfile
@@ -12,8 +12,7 @@ ARG jmx_exporter_bin="https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prome
 
 
 ENV METASTORE_HOME=/opt/hive-metastore \
-    HADOOP_HOME=/opt/hadoop \
-    HADOOP_OPTS="-Xms768m -Xmx768m -XX:NewSize=300m"
+    HADOOP_HOME=/opt/hadoop
 RUN set -ex && \
     apk add --no-cache bash tini libc6-compat linux-pam && \
     mkdir -p /opt && \