Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trino charts - branch name is wrong #487

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

ian-j-abbott-accenture
Copy link
Contributor

Description

What was changed

Reminders

  • Did you up the relevant chart version numbers? (If appropriate)
    • If you up a chart version within urban-os, have you also upped the urban-os chart version itself?
    • If charts within the urban-os chart (andi, etc) have been updated, have you run helm dependency update in /charts/urban-os and commited the Chart.lock file?
  • Does helm template . -f values.yaml pass? (Checks for default values provided in chart and catches other errors)
  • Do you have git hooks installed? (See README.md to install)
  • If global values were altered, are they included as chart default values?
    • Are they also specified in the urbanos chart values file?
  • If references to external charts were added:
    • Was the github release action updated to helm update {new_thing} it's dependencies?
    • Was the deploy repo -u flag updated to helm update {new_thing} to ensure it's not left out of deployments?

@ian-j-abbott-accenture ian-j-abbott-accenture merged commit a6128ce into master Jan 7, 2025
1 check passed
@ian-j-abbott-accenture ian-j-abbott-accenture deleted the bump-kafka-chart branch January 7, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant