Skip to content

Commit

Permalink
Porting guide: Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rtabbara committed Oct 2, 2024
1 parent 0786eeb commit 9d7d052
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions docs/porting_3_6.rst
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,10 @@ C++ interface changes
.. _dr_cpp: https://drjit.readthedocs.io/en/latest/cpp.html

Mitsuba 3.6.0 has also introduced changes that affect C++ developers who have
extended Mitusba 3, such as by defining custom C++ plugins. As with the Python
interface, most of these changes are driven by Dr.Jit 1.0.0 and we again
recommend users first begin by reading the `Dr.Jit documentation <dr_main_>`_
and in particular the dedicated section on the `Dr.Jit C++ interface <dr_cpp_>`_.
extended Mitsuba 3. As with the Python interface, most of these changes are
driven by Dr.Jit 1.0.0 and we again recommend users first begin by reading
the `Dr.Jit documentation <dr_main_>`_ and in particular the dedicated section
on the `Dr.Jit C++ interface <dr_cpp_>`_.

Control flow
~~~~~~~~~~~~
Expand Down Expand Up @@ -326,8 +326,8 @@ result
Dr.Jit 1.0.0 removes ``drjit::eq`` and ``drjit::neq`` which are replaced by the
overloaded operators ``==`` and ``!=`` respectively. Any reductions now have
to be explicitly specified by for instance using the :py:func:`drjit.all` or
:py:func:`drjit.any` functions
to be explicitly specified by using the :py:func:`drjit.all` or
:py:func:`drjit.any` functions for instance

.. code-block:: cpp
Expand All @@ -346,7 +346,7 @@ codebases that read or modify the storage directly, for example
dr::Matrix<Float, 3> m = ...;
// Returned array is now is first row, not column!
// Returned array is now first row, not column!
auto& v = m.entry(0);
Expand Down

0 comments on commit 9d7d052

Please sign in to comment.