Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results of the document approval process are not saved #33

Open
kkh451 opened this issue Feb 28, 2018 · 4 comments
Open

Results of the document approval process are not saved #33

kkh451 opened this issue Feb 28, 2018 · 4 comments
Labels
On Hold Issue is pending information or advice from a third party

Comments

@kkh451
Copy link
Collaborator

kkh451 commented Feb 28, 2018 •
edited
Loading

Document status reverts to "unapproved" after conducting document approval and logging out.
@kkh451 kkh451 added the bug label Feb 28, 2018
@workyjim
Copy link
Collaborator

Following additional testing, not only is document approval still failing, but unapproved documents are available on study details. Further invetigation required.

@workyjim workyjim mentioned this issue Oct 12, 2018
Closed
@workyjim workyjim added this to the Pre-launch essentials milestone Dec 17, 2018
@workyjim
Copy link
Collaborator

Updated to save via FileRepo instead of Study = this should fix. Models and views updated to prevent display of unapproved documents.

workyjim pushed a commit that referenced this issue Dec 17, 2018
Ref githgub issue #33
43e92c9
workyjim pushed a commit that referenced this issue Dec 17, 2018
Ref github issue #33
6c76421
@kkh451
Copy link
Collaborator Author

kkh451 commented Jan 7, 2019

Testing indicates that multiple issues remain; results of document approval are not saved and files become available for download immediately before having been approved.

@kkh451 kkh451 reopened this Jan 7, 2019
@workyjim
Copy link
Collaborator

Per kkh/IG document approval no longer needed. Design modified to show document regardless of approval. Approval system untouched allowing re-examination if requirements change. Issue removed from milestone and put on hold.

@workyjim workyjim added On Hold Issue is pending information or advice from a third party and removed bug critical high priority labels Jan 14, 2019
@workyjim workyjim removed this from the Pre-launch essentials milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
On Hold Issue is pending information or advice from a third party
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkh451 @workyjim