Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a databaseSecrets value to populate the DATABASE variables #186

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

sshort
Copy link
Contributor

@sshort sshort commented Feb 6, 2025

About the changes

Add a databaseSecrets value to populate the DATABASE_ host, port, username and password vars from secret file.

Closes #183

Important files

Discussion points

@chriswk chriswk self-assigned this Feb 11, 2025
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sshort - thank you for this contribution. Could I trouble you to bump the patch version in the Chart.yaml so our linter succeeds?

@chriswk
Copy link
Member

chriswk commented Feb 12, 2025

So sorry, but one more iteration seems to be needed, the spelling mistake in the comment in the values file
./charts/unleash/values.yaml:64: enviroment ==> environment
and according to the linter, there's trailing spaces in the file.
I think https://github.com/Unleash/helm-charts/actions/runs/13261095809/job/37078665843?pr=186 should be visible for you as well.

We need these two to pass in order for the more important tests to run (kubeconform and install-charts).
Can I trouble you one more time?

@chriswk
Copy link
Member

chriswk commented Feb 21, 2025

All green here. Again, thank you, will merge :)

@chriswk chriswk merged commit f9e9a4f into Unleash:main Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Read database connection info from secrets created by Crossplane RDSInstance
2 participants