Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raw Stmt/Value/Type #291

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add Raw Stmt/Value/Type #291

merged 1 commit into from
Jan 17, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jan 16, 2025

This PR adds "Raw" (or rather, "unrecognized", "unsupported", "unknown", "unhandled") statements/values/types with custom de/serializers. This PR also removes all toString() for DTOs, because toString() is only meaningful for the "real" objects in Ets hierarchy.

@Lipen Lipen requested a review from CaelmBleidd January 16, 2025 22:45
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   2m 36s ⏱️ -2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit ef2a362. ± Comparison against base commit fe53361.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test results on JDK 19

 69 files  ±0   69 suites  ±0   4m 53s ⏱️ -23s
597 tests +3  587 ✅ +3  10 💤 ±0  0 ❌ ±0 
667 runs  +3  657 ✅ +3  10 💤 ±0  0 ❌ ±0 

Results for commit ef2a362. ± Comparison against base commit fe53361.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test results on JDK 11

 69 files  ±0   69 suites  ±0   5m 22s ⏱️ -7s
597 tests +3  589 ✅ +3  8 💤 ±0  0 ❌ ±0 
667 runs  +3  659 ✅ +3  8 💤 ±0  0 ❌ ±0 

Results for commit ef2a362. ± Comparison against base commit fe53361.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Test results on JDK 8

 69 files  ±0   69 suites  ±0   7m 47s ⏱️ +10s
597 tests +3  584 ✅ +3  13 💤 ±0  0 ❌ ±0 
667 runs  +3  654 ✅ +3  13 💤 ±0  0 ❌ ±0 

Results for commit ef2a362. ± Comparison against base commit fe53361.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 47.78761% with 59 lines in your changes missing coverage. Please review.

Project coverage is 71.50%. Comparing base (fe53361) to head (ef2a362).
Report is 1 commits behind head on neo.

Files with missing lines Patch % Lines
...ets/src/main/kotlin/org/jacodb/ets/base/EtsType.kt 0.00% 11 Missing ⚠️
...s/src/main/kotlin/org/jacodb/ets/base/EtsEntity.kt 0.00% 10 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/base/EtsStmt.kt 0.00% 10 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 0.00% 9 Missing ⚠️
.../src/main/kotlin/org/jacodb/ets/dto/Serializers.kt 81.25% 6 Missing and 3 partials ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Types.kt 58.33% 5 Missing ⚠️
...b-ets/src/main/kotlin/org/jacodb/ets/dto/Values.kt 25.00% 3 Missing ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Model.kt 80.00% 1 Missing ⚠️
...s/src/main/kotlin/org/jacodb/ets/dto/Signatures.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #291      +/-   ##
============================================
+ Coverage     70.78%   71.50%   +0.71%     
  Complexity     2438     2438              
============================================
  Files           252      252              
  Lines         14608    14507     -101     
  Branches       2109     2098      -11     
============================================
+ Hits          10341    10373      +32     
+ Misses         3393     3264     -129     
+ Partials        874      870       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen merged commit 0d1a79f into neo Jan 17, 2025
9 of 10 checks passed
@Lipen Lipen deleted the lipen/raw branch January 17, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants