Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ops into dto package and split into Unary/Binary/Relational #290

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jan 16, 2025

This PR splits Ops into unary/binary/relational operations and moves it to a more suitable dto package.

@Lipen Lipen requested a review from CaelmBleidd January 16, 2025 22:44
Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   2m 36s ⏱️ ±0s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 5a52695. ± Comparison against base commit 983d353.

Copy link
Contributor

Test results on JDK 19

 69 files  ±0   69 suites  ±0   4m 52s ⏱️ +4s
594 tests ±0  584 ✅ ±0  10 💤 ±0  0 ❌ ±0 
664 runs  ±0  654 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 5a52695. ± Comparison against base commit 983d353.

Copy link
Contributor

Test results on JDK 11

 69 files  ±0   69 suites  ±0   5m 26s ⏱️ -2s
594 tests ±0  586 ✅ ±0  8 💤 ±0  0 ❌ ±0 
664 runs  ±0  656 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 5a52695. ± Comparison against base commit 983d353.

Copy link
Contributor

Test results on JDK 8

 69 files  ±0   69 suites  ±0   7m 35s ⏱️ -2s
594 tests ±0  581 ✅ ±0  13 💤 ±0  0 ❌ ±0 
664 runs  ±0  651 ✅ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit 5a52695. ± Comparison against base commit 983d353.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.80%. Comparing base (983d353) to head (5a52695).
Report is 1 commits behind head on neo.

Files with missing lines Patch % Lines
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 74.19% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                neo     #290   +/-   ##
=========================================
  Coverage     70.80%   70.80%           
  Complexity     2438     2438           
=========================================
  Files           252      252           
  Lines         14608    14608           
  Branches       2109     2109           
=========================================
  Hits          10343    10343           
  Misses         3393     3393           
  Partials        872      872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen merged commit fe53361 into neo Jan 17, 2025
12 checks passed
@Lipen Lipen deleted the lipen/ops branch January 17, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants