Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize EtsIR DTOs #288

Merged
merged 31 commits into from
Jan 15, 2025
Merged

Reorganize EtsIR DTOs #288

merged 31 commits into from
Jan 15, 2025

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jan 9, 2025

This PR improves DTOs for EtsIR. Also, it adds the dynamic tests for loading (and auto-converting) available samples from resources. And it also adds some new values and statements introduced in the latest ArkAnalyzer.

@Lipen Lipen requested a review from CaelmBleidd January 9, 2025 15:50
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   2m 36s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit c51b575. ± Comparison against base commit c53062b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test results on JDK 19

 69 files  ± 0   69 suites  ±0   4m 53s ⏱️ +15s
594 tests +42  584 ✅ +42  10 💤 ±0  0 ❌ ±0 
664 runs  +84  654 ✅ +84  10 💤 ±0  0 ❌ ±0 

Results for commit c51b575. ± Comparison against base commit c53062b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test results on JDK 11

 69 files  ± 0   69 suites  ±0   5m 29s ⏱️ +28s
594 tests +42  586 ✅ +42  8 💤 ±0  0 ❌ ±0 
664 runs  +84  656 ✅ +84  8 💤 ±0  0 ❌ ±0 

Results for commit c51b575. ± Comparison against base commit c53062b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test results on JDK 8

 69 files  ± 0   69 suites  ±0   7m 34s ⏱️ +7s
594 tests +42  581 ✅ +42  13 💤 ±0  0 ❌ ±0 
664 runs  +84  651 ✅ +84  13 💤 ±0  0 ❌ ±0 

Results for commit c51b575. ± Comparison against base commit c53062b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 56.89655% with 150 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (ad5e1f1) to head (c51b575).
Report is 3 commits behind head on neo.

Files with missing lines Patch % Lines
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 68.95% 57 Missing and 29 partials ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/base/EtsRef.kt 0.00% 16 Missing ⚠️
...b-ets/src/main/kotlin/org/jacodb/ets/dto/Values.kt 0.00% 16 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/base/EtsStmt.kt 0.00% 7 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/base/EtsType.kt 0.00% 7 Missing ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Stmts.kt 42.85% 4 Missing ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Types.kt 0.00% 4 Missing ⚠️
...rc/main/kotlin/org/jacodb/ets/utils/GetOperands.kt 0.00% 4 Missing ⚠️
...ts/src/main/kotlin/org/jacodb/ets/base/EtsValue.kt 0.00% 3 Missing ⚠️
...rc/main/kotlin/org/jacodb/ets/utils/LoadEtsFile.kt 60.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #288      +/-   ##
============================================
+ Coverage     69.94%   70.79%   +0.84%     
- Complexity     2436     2438       +2     
============================================
  Files           252      252              
  Lines         14582    14608      +26     
  Branches       2107     2109       +2     
============================================
+ Hits          10200    10342     +142     
+ Misses         3499     3393     -106     
+ Partials        883      873      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen marked this pull request as draft January 10, 2025 15:20
@Lipen Lipen marked this pull request as ready for review January 13, 2025 17:02
@Lipen Lipen merged commit 983d353 into neo Jan 15, 2025
9 of 10 checks passed
@Lipen Lipen deleted the lipen/dto branch January 15, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants