Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ets BinOp enum classes #248

Closed
wants to merge 1 commit into from
Closed

Refactor Ets BinOp enum classes #248

wants to merge 1 commit into from

Conversation

zishkaz
Copy link
Collaborator

@zishkaz zishkaz commented Aug 1, 2024

No description provided.

@zishkaz zishkaz requested a review from Lipen August 1, 2024 13:30
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 53s ⏱️ -2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit feb378a. ± Comparison against base commit 133474f.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   25m 50s ⏱️ +18s
2 511 tests ±0  2 469 ✅ ±0  42 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 497 ✅ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit feb378a. ± Comparison against base commit 133474f.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes missing coverage. Please review.

Project coverage is 60.01%. Comparing base (133474f) to head (feb378a).

Files Patch % Lines
...odb-ets/src/main/kotlin/org/jacodb/ets/base/Ops.kt 43.18% 24 Missing and 1 partial ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #248      +/-   ##
============================================
- Coverage     60.03%   60.01%   -0.03%     
- Complexity     2244     2247       +3     
============================================
  Files           310      310              
  Lines         18122    18115       -7     
  Branches       3259     3261       +2     
============================================
- Hits          10880    10872       -8     
- Misses         6164     6166       +2     
+ Partials       1078     1077       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   29m 57s ⏱️ - 1m 43s
2 511 tests ±0  2 471 ✅ ±0  40 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 499 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit feb378a. ± Comparison against base commit 133474f.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   31m 8s ⏱️ - 1m 15s
2 511 tests ±0  2 466 ✅ ±0  45 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 494 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit feb378a. ± Comparison against base commit 133474f.

@Lipen
Copy link
Member

Lipen commented Aug 2, 2024

@zishkaz Thanks for your effort! Your changes are now superseded by #249. Please, review it and compare the usability.

@Lipen Lipen closed this Aug 2, 2024
@Lipen Lipen deleted the sergeyl/binop branch August 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants