Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep local variable names feature #215

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

sergeypospelov
Copy link
Member

@sergeypospelov sergeypospelov commented Feb 7, 2024

For debug and test purposes, I need a feature to see original local variable names instead of stuff like %0, %42, arg$13, etc.

  • Added setting keepLocalVariableNames
  • MethodInstructionsFeature became class
  • Modified RawInstListBuilder and Simplifier
  • IMPORTANT: Added index field to JcLocalVar, JcRawLocalVar.
  • IMPORTANT: Now name field is ignored in equals and hashCode in Jc(Raw)LocalVar and Jc(Raw)Argument

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Lifecycle test results

48 tests  ±0   48 ✅ ±0   1m 27s ⏱️ +3s
 5 suites ±0    0 💤 ±0 
 5 files   ±0    0 ❌ ±0 

Results for commit dc763e9. ± Comparison against base commit 1a0fb7e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test results on JDK 8

1 274 tests  +1   1 261 ✅ +1   4m 12s ⏱️ +6s
   46 suites ±0      13 💤 ±0 
   46 files   ±0       0 ❌ ±0 

Results for commit dc763e9. ± Comparison against base commit 1a0fb7e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test results on JDK 11

1 274 tests  +1   1 265 ✅ +1   4m 33s ⏱️ -3s
   46 suites ±0       9 💤 ±0 
   46 files   ±0       0 ❌ ±0 

Results for commit dc763e9. ± Comparison against base commit 1a0fb7e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Test results on JDK 19

1 274 tests  +1   1 263 ✅ +1   4m 16s ⏱️ +6s
   46 suites ±0      11 💤 ±0 
   46 files   ±0       0 ❌ ±0 

Results for commit dc763e9. ± Comparison against base commit 1a0fb7e.

♻️ This comment has been updated with latest results.

@sergeypospelov sergeypospelov force-pushed the sergey/local_variable_names branch from 37b52a5 to 063a0b4 Compare February 7, 2024 14:20
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1a0fb7e) 77.05% compared to head (dc763e9) 77.26%.

Files Patch % Lines
...n/kotlin/org/jacodb/impl/cfg/RawInstListBuilder.kt 90.69% 0 Missing and 4 partials ⚠️
...analysis/impl/StringConcatSimplifierTransformer.kt 66.66% 2 Missing ⚠️
...in/kotlin/org/jacodb/impl/cfg/JcInstListBuilder.kt 33.33% 2 Missing ⚠️
.../src/main/kotlin/org/jacodb/impl/cfg/Simplifier.kt 93.93% 0 Missing and 2 partials ⚠️
.../src/main/kotlin/org/jacodb/impl/JcDatabaseImpl.kt 50.00% 1 Missing ⚠️
...in/kotlin/org/jacodb/impl/cfg/MethodNodeBuilder.kt 87.50% 0 Missing and 1 partial ⚠️
...mpl/features/classpaths/virtual/JcVirtualMethod.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #215      +/-   ##
=============================================
+ Coverage      77.05%   77.26%   +0.21%     
- Complexity      1633     1662      +29     
=============================================
  Files            166      166              
  Lines           9565     9615      +50     
  Branches        1698     1711      +13     
=============================================
+ Hits            7370     7429      +59     
+ Misses          1513     1507       -6     
+ Partials         682      679       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergeypospelov sergeypospelov merged commit 389ea0f into develop Feb 8, 2024
14 checks passed
@sergeypospelov sergeypospelov deleted the sergey/local_variable_names branch February 8, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants