Choose bidi runner via globals

UnitTestBot · Feb 6, 2024 · ca1ebf3 · ca1ebf3
1 parent edbd76f
commit ca1ebf3
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 31 deletions.
diff --git a/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/TaintAnalyzers.kt b/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/TaintAnalyzers.kt
@@ -33,10 +33,6 @@ import org.jacodb.taint.configuration.TaintMethodSink
 
 private val logger = KotlinLogging.logger {}
 
-internal object Globals {
-    internal var TAINTED_LOOP_BOUND_SINK = false
-}
-
 class TaintAnalyzer(
     private val graph: JcApplicationGraph,
 ) : Analyzer<TaintFact, TaintEvent> {

diff --git a/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/TaintManager.kt b/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/TaintManager.kt
@@ -35,6 +35,7 @@ import kotlinx.coroutines.yield
 import org.jacodb.analysis.engine.SummaryStorageImpl
 import org.jacodb.analysis.engine.UnitResolver
 import org.jacodb.analysis.engine.UnitType
+import org.jacodb.analysis.graph.reversed
 import org.jacodb.analysis.ifds2.ControlEvent
 import org.jacodb.analysis.ifds2.Manager
 import org.jacodb.analysis.ifds2.QueueEmptinessChanged
@@ -71,34 +72,37 @@ class TaintManager(
     ): TaintRunner {
         check(unit !in runnerForUnit) { "Runner for $unit already exists" }
 
-        val analyzer = TaintAnalyzer(graph)
-        val runner = Runner(graph, analyzer, this@TaintManager, unitResolver, unit)
+        val runner = if (Globals.BIDI_RUNNER) {
+            BidiRunner(
+                manager = this@TaintManager,
+                unitResolver = unitResolver,
+                unit = unit,
+                { manager ->
+                    val analyzer = TaintAnalyzer(graph)
+                    Runner(
+                        graph = graph,
+                        analyzer = analyzer,
+                        manager = manager,
+                        unitResolver = unitResolver,
+                        unit = unit
+                    )
+                },
+                { manager ->
+                    val analyzer = BackwardTaintAnalyzer(graph)
+                    Runner(
+                        graph = graph.reversed,
+                        analyzer = analyzer,
+                        manager = manager,
+                        unitResolver = unitResolver,
+                        unit = unit
+                    )
+                }
+            )
+        } else {
+            val analyzer = TaintAnalyzer(graph)
+            Runner(graph, analyzer, this@TaintManager, unitResolver, unit)
+        }
 
-        // val runner = BidiRunner(
-        //     manager = this@TaintManager,
-        //     unitResolver = unitResolver,
-        //     unit = unit,
-        //     { manager ->
-        //         val analyzer = TaintAnalyzer(graph)
-        //         Runner(
-        //             graph = graph,
-        //             analyzer = analyzer,
-        //             manager = manager,
-        //             unitResolver = unitResolver,
-        //             unit = unit
-        //         )
-        //     },
-        //     { manager ->
-        //         val analyzer = BackwardTaintAnalyzer(graph)
-        //         Runner(
-        //             graph = graph.reversed,
-        //             analyzer = analyzer,
-        //             manager = manager,
-        //             unitResolver = unitResolver,
-        //             unit = unit
-        //         )
-        //     }
-        // )
         runnerForUnit[unit] = runner
         return runner
     }

diff --git a/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/globals.kt b/jacodb-analysis/src/main/kotlin/org/jacodb/analysis/ifds2/taint/globals.kt
@@ -0,0 +1,22 @@
+/*
+ *  Copyright 2022 UnitTestBot contributors (utbot.org)
+ * <p>
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ * <p>
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.jacodb.analysis.ifds2.taint
+
+internal object Globals {
+    var BIDI_RUNNER = true
+    var TAINTED_LOOP_BOUND_SINK = false
+}