Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump sor to 4.17.7 - fix: mixed route support ETH <-> WETH #819

Merged
merged 8 commits into from
Feb 7, 2025
Merged

chore: bump sor to 4.17.7 - fix: mixed route support ETH <-> WETH #819

merged 8 commits into from
Feb 7, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Feb 3, 2025 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    mixed route cannot support ETH <-> WETH

  • What is the new behavior (if this is a feature change)?
    mixed route to support ETH <-> WETH

  • Other information:
    still debugging the route string

@jsy1218 Graphite App
Copy link
Member Author

jsy1218 commented Feb 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security Socket Security
Copy link

socket-security bot commented Feb 3, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/router-sdk@1.22.1 🔁 npm/@uniswap/router-sdk@1.21.0 Transitive: network +27 3.06 MB uniswap-labs-service-account
npm/@uniswap/universal-router-sdk@4.17.0 🔁 npm/@uniswap/universal-router-sdk@4.14.0 None +5 94.3 MB uniswap-labs-owner-account, uniswap-labs-service-account
npm/@uniswap/v4-sdk@1.19.2 🔁 npm/@uniswap/v4-sdk@1.18.0 None +15 1.69 MB uniswap-labs-owner-account, uniswap-labs-service-account

View full report↗︎

@jsy1218 jsy1218 marked this pull request as ready for review February 3, 2025 22:41
@jsy1218 jsy1218 requested a review from a team as a code owner February 3, 2025 22:41
@graphite-app graphite-app bot requested review from cgkol and xrsv February 3, 2025 22:43
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 3, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (02/03/25)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

xrsv
xrsv reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@xrsv xrsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - ideally add some unit tests to verify the computeAllRoutes new logic

@jsy1218 jsy1218 requested a review from xrsv February 7, 2025 04:42
xrsv
xrsv approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@xrsv xrsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - if all e2e tests pass in routing api side
just left a couple of comments to double check

@jsy1218 jsy1218 merged commit c0caf26 into main Feb 7, 2025
20 of 32 checks passed
@jsy1218 jsy1218 deleted the siyujiang/sor-4.17.7-mixed-route-eth-weth branch February 7, 2025 16:16
@jsy1218 jsy1218 mentioned this pull request Feb 7, 2025
Merged
jsy1218 added a commit that referenced this pull request Feb 7, 2025
@jsy1218
4.17.10 (#821)
81ec7fc 
Rlease #819
jsy1218 added a commit that referenced this pull request Feb 7, 2025
@jsy1218
Revert: chore: bump sor to 4.17.7 - fix: mixed route support ETH <-> …
f451675 
…WETH (#819)
jsy1218 added a commit that referenced this pull request Feb 7, 2025
@jsy1218
Revert: chore: bump sor to 4.17.7 - fix: mixed route support ETH <-> …
7112718 
…WETH (#819) (#823)

- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)

- **What is the current behavior?** (You can also link to an open issue here)

- **What is the new behavior (if this is a feature change)?**

- **Other information**:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrsv xrsv xrsv approved these changes

@cgkol cgkol Awaiting requested review from cgkol

Assignees

@jsy1218 jsy1218

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsy1218 @xrsv