Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.17.2 - fix: Implement check for sellReverted boolean in transfer detector contract #806

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jan 27, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    We allow the sellReverted FOT token to be included in routing.

  • What is the new behavior (if this is a feature change)?
    We shouldn't allow the sellReverted FOT token to be included in routing

  • Other information:

Copy link
Member Author

jsy1218 commented Jan 27, 2025

@jsy1218 jsy1218 marked this pull request as ready for review January 27, 2025 23:13
@jsy1218 jsy1218 requested a review from a team as a code owner January 27, 2025 23:13
@graphite-app graphite-app bot requested review from xrsv and cgkol January 27, 2025 23:13
Copy link

graphite-app bot commented Jan 27, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (01/27/25)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test? also shall we also change the implementaion on graphQL to reflect the change given that we are reading from there to cache first?

@xrsv
Copy link
Contributor

xrsv commented Jan 27, 2025

Shall we add a test? also shall we also change the implementaion on graphQL to reflect the change given that we are reading from there to cache first?

Good call @cgkol - We probably need to make similar changes in the cached path here. Plus a test would be nice

@jsy1218
Copy link
Member Author

jsy1218 commented Jan 28, 2025

Shall we add a test? also shall we also change the implementaion on graphQL to reflect the change given that we are reading from there to cache first?

Good call @cgkol - We probably need to make similar changes in the cached path here. Plus a test would be nice

leaning toward adding a test in routing-api, because the actual contract call will be through GQL. ok to add test in token fetcher class, but that's not being used in routing-api actually.

Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@jsy1218
Copy link
Member Author

jsy1218 commented Jan 29, 2025

it doesn't fix

@jsy1218 jsy1218 closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants