-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sor to 4.17.2 - fix: Implement check for sellReverted boolean in transfer detector contract #806
Conversation
…lean in transfer detector contract
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (01/27/25)3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a test? also shall we also change the implementaion on graphQL to reflect the change given that we are reading from there to cache first?
Good call @cgkol - We probably need to make similar changes in the cached path here. Plus a test would be nice |
leaning toward adding a test in routing-api, because the actual contract call will be through GQL. ok to add test in token fetcher class, but that's not being used in routing-api actually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
it doesn't fix |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
We allow the sellReverted FOT token to be included in routing.
What is the new behavior (if this is a feature change)?
We shouldn't allow the sellReverted FOT token to be included in routing
Other information: