Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sor): support routing on unichain mainnet #766

Merged
merged 17 commits into from
Jan 23, 2025

Conversation

xrsv
Copy link
Contributor

@xrsv xrsv commented Nov 21, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Support routing in SOR for Unichain Mainnet.

  • Other information:
    Pending

    • add github repo secrets for integrations tests
    • Validate USDC token address
    • Find a whale address for unichain mainnet tests

@xrsv xrsv requested a review from a team as a code owner November 21, 2024 20:46
@xrsv xrsv requested review from jsy1218 and cgkol November 21, 2024 20:46
Copy link
Contributor

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge, can we test that the quotes are returned correctly locally with real on chain data?

@graphite-app graphite-app bot requested review from a team and cgkol November 25, 2024 17:11
Copy link

graphite-app bot commented Nov 25, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (11/25/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

@xrsv
Copy link
Contributor Author

xrsv commented Jan 23, 2025

Before we merge, can we test that the quotes are returned correctly locally with real on chain data?

tested in works for V2 pool. For v3 we have very low liquidity DAI, so we get no route, but I'll check in what we have to unblock FE.

@xrsv xrsv merged commit 0ec3ddb into main Jan 23, 2025
18 of 31 checks passed
@xrsv xrsv deleted the xrsv/sor-unichain-mainnet-support branch January 23, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants