Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): revert update npm dependencies #624

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mr-uniswap
Copy link
Contributor

Reverts #622

@mr-uniswap mr-uniswap requested a review from a team as a code owner June 28, 2024 20:19
@mr-uniswap mr-uniswap changed the title Revert "chore(deps): update npm dependencies" chore(deps): revert update npm dependencies Jun 28, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
CVE npm/braces@3.0.2 ⚠︎
CVE npm/json5@2.2.1 ⚠︎
CVE npm/json5@1.0.1 ⚠︎
Critical CVE npm/@babel/traverse@7.18.2 ⚠︎
CVE npm/moment@2.29.3 ⚠︎
CVE npm/undici@5.12.0 ⚠︎
Network access npm/undici@5.12.0 ⚠︎
Install scripts npm/@eth-optimism/contracts-bedrock@0.17.1
  • Install script: preinstall
  • Source: npx only-allow pnpm
⚠︎

View full report↗︎

Next steps

What is a CVE?

Contains a high severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/braces@3.0.2
  • @SocketSecurity ignore npm/json5@2.2.1
  • @SocketSecurity ignore npm/json5@1.0.1
  • @SocketSecurity ignore npm/@babel/traverse@7.18.2
  • @SocketSecurity ignore npm/moment@2.29.3
  • @SocketSecurity ignore npm/undici@5.12.0
  • @SocketSecurity ignore npm/@eth-optimism/contracts-bedrock@0.17.1

@graphite-app graphite-app bot requested review from xrsv and mikeki June 28, 2024 20:21
@graphite-app graphite-app bot requested a review from cgkol June 28, 2024 20:21
Copy link

graphite-app bot commented Jun 28, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (06/28/24)

4 reviewers were added and 1 assignee was added to this PR based on 's automation.

@mr-uniswap mr-uniswap enabled auto-merge (squash) June 28, 2024 20:45
@mr-uniswap mr-uniswap merged commit fe6f450 into main Jun 28, 2024
23 of 26 checks passed
@mr-uniswap mr-uniswap deleted the revert-622-fix/npm-audit-fix branch June 28, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants