feature: introduce a ITokenFeeFetcher fallback
#603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (06/12/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
mikeki
reviewed
Jun 13, 2024
Comment on lines
+127
to
+150
| if (this.tokenFeeFetcherFallback) { | ||
| // If a fallback fetcher is provided, we will use it to fetch fees for tokens that were not fetched by the primary fetcher. | ||
| const addressesToFetchFeesWithFallbackFetcher = addressesToFetchFees.filter( | ||
| (address) => !tokenFeeMap[address] | ||
| ); | ||
| if (addressesToFetchFeesWithFallbackFetcher.length > 0) { | ||
| try { | ||
| const tokenFeeMapFromFallback = await this.tokenFeeFetcherFallback.fetchFees( | ||
| addressesToFetchFeesWithFallbackFetcher, | ||
| providerConfig | ||
| ); | ||
| tokenFeeMap = { | ||
| ...tokenFeeMap, | ||
| ...tokenFeeMapFromFallback, | ||
| }; | ||
| } catch (err) { | ||
| log.error( | ||
| { err }, | ||
| `Error fetching fees for tokens ${addressesToFetchFeesWithFallbackFetcher} using fallback` | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
What do you think about creating a GraphQlTokenFeeFetcherWithFallback implementation of ITokenFeeFetcher, and we put that in routing-api instead of here?
That way we could avoid all changes in SOR, we just need to make sure that the tokenFeeFetcher can be overwritten in routing-api.
There was a problem hiding this comment.
that's not a bad idea, let me do that.
There was a problem hiding this comment.
I like @mikeki 's idea. Then in routing-api, we can create a traffic switch fetcher class (similar to lib/handlers/quote/provider-migration/v3/traffic-switch-on-chain-quote-provider.ts), that can achieve:
- beginning by shadow calling GQL token fetcher without affecting online path
- compare the results between GQL token fetcher and direct on-chain token fetcher
- gradually switching from direct on-chain token fetcher to GQL token fetcher
- and the existing traffic switch implementation already guarantees that in case GQL token fetcher throws error, it will fallback to use GQL token fetcher. We will just have to tweak the implementation a bit, so that when GQL token fetcher returns 0 fee, it also fallback to direct on-chain token fetcher to try fetching the FOT fee again. Since direct on-chain token fetcher is wrapped with in-memory cache, perf penalty in those fallbacks are minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
We currently use one
ITokenFeeFetcherimplementation to retrieve token feesWhat is the new behavior (if this is a feature change)?
we are introducing an optional fallback
ITokenFeeFetcherthat will be used to retrieve token fee info in case primary fails, or if some tokens are not present in primary.Plan is to use primary for our graphQL provider, then fallback to onchain fetch in case anything goes wrong or missing.
Other information:
a separate PR will follow on routing-api repo