feat: Introduce GraphQLTokenFeeFetcher (no traffic)
#736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrsv
commented
Jun 13, 2024
mikeki
reviewed
Jun 13, 2024
|
Pasting my comments from old PR. I think we want to shadow sample GQL traffic first, with FOT fee comparison. We aren't in rush to switch 10% (or whatever) traffic to GQL |
makes sense - I'll remove the traffic switch part from this PR and will add that logic to a different PR |
xrsv
changed the title
GraphQLTokenFeeFetcher at 10% trafficGraphQLTokenFeeFetcher (no traffic)
graphite-app
bot
requested review from
a team,
uni-guillaume,
mikeki and
cgkol
and removed request for
a team and
uni-guillaume
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/13/24)5 reviewers were added and 1 assignee was added to this PR based on 's automation. |
jsy1218
reviewed
Jun 14, 2024
jsy1218
reviewed
Jun 14, 2024
jsy1218
reviewed
Jun 14, 2024
jsy1218
reviewed
Jun 14, 2024
jsy1218
reviewed
Jun 14, 2024
jsy1218
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a
GraphQLTokenFeeFetcher(implementation + tests only for now, no live traffic)This fetcher will use GraphQL endpoint to fetch token fee data, and will fallback to OnChain fetching if something goes wrong or to fetch any remaining tokens that couldn't be fetched from graphQL.
Did setup env variables
UNI_GRAPHQL_ENDPOINT/UNI_GRAPHQL_HEADER_ORIGINfor GraphQL in routing-apiA separate PR will follow for shadow traffic,
Testing