-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hvPlot
in Plotting API, Add Polygon Projection Support
#922
Conversation
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
Benchmarks that have got worse:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Is there a better mesh you could use for the notebook example? Maybe with more cells? And possibly without the holes? It can be confusing to look at. Also now that I am thinking about it, we should start using the UXarray colormaps for the notebooks. |
Agree with all the points here. I thought the PR was ready for review (but quickly turned it back to draft). I'll address this points! |
Co-authored-by: Orhan Eroglu <32553057+erogluorhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resolved the previous comments and now added a few more as part of my second round of review
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am now good with all of the code here.
This PR seems to be reducing the code coverage though, and some of them looks real (e.g. _correct_central_longitude
or part of it does not seem to be covered). I might be missing some contextvfrom the rest of the review process though. Could you clarify?
Thanks for the comprehensive review! I've made a few changes since writing the initial tests as I've been addressing the reviews. I'll get those added and look into improving the code coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work and marks a visualization milestone with the projections support it brings!
Closes #849 #493 #918 #625
Overview
hvPlot
to_geoataframe()
methods to better align with recent changes toto_polycollection()
geopandas.GeoDataFrame
using theengine='geopandas'
parameter