Merge pull request #1077 from UXARRAY/philipc2/disable-numba-for-tests

Disable `numba` for code coverage
UXARRAY · Nov 18, 2024 · 93309d2 · 93309d2
2 parents 8fc8d52 + dfd9c76
commit 93309d2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -62,13 +62,16 @@ jobs:
         run: |
           conda list
 
+
       - name: Run Namespace Tests
         run: |
           python -m pytest test
 
       - name: Run Coverage Tests
         run: |
           python -m pytest test -v --cov=./uxarray --cov-report=xml
+        env:
+          NUMBA_DISABLE_JIT: 1
 
       - name: Upload code coverage to Codecov
         if: github.repository == 'UXARRAY/uxarray'

diff --git a/uxarray/grid/coordinates.py b/uxarray/grid/coordinates.py
@@ -1,6 +1,5 @@
 import xarray as xr
 import numpy as np
-import math
 import warnings
 
 from uxarray.conventions import ugrid
@@ -53,8 +52,8 @@ def _xyz_to_lonlat_rad_no_norm(
         Latitude in radians
     """
 
-    lon = math.atan2(y, x)
-    lat = math.asin(z)
+    lon = np.atan2(y, x)
+    lat = np.asin(z)
 
     # set longitude range to [0, pi]
     lon = np.mod(lon, 2 * np.pi)
@@ -102,8 +101,8 @@ def _xyz_to_lonlat_rad_scalar(
         y /= denom
         z /= denom
 
-    lon = math.atan2(y, x)
-    lat = math.asin(z)
+    lon = np.atan2(y, x)
+    lat = np.asin(z)
 
     # set longitude range to [0, pi]
     lon = np.mod(lon, 2 * np.pi)
@@ -790,8 +789,8 @@ def _xyz_to_lonlat_rad_no_norm(
         Latitude in radians
     """
 
-    lon = math.atan2(y, x)
-    lat = math.asin(z)
+    lon = np.atan2(y, x)
+    lat = np.asin(z)
 
     # set longitude range to [0, pi]
     lon = np.mod(lon, 2 * np.pi)