Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a post announcing the Local and Regional Working Group #876

Merged
merged 10 commits into from
Aug 20, 2022
Merged

Add a post announcing the Local and Regional Working Group #876

merged 10 commits into from
Aug 20, 2022

Conversation

rafmudaf
Copy link
Contributor

@rafmudaf rafmudaf commented Aug 9, 2022

Description

This pull request adds a post describing the Local and Regional Working Group that was established during the 2022 Community Building Workshop. There's a companion pull request to the us-rse map repository.

Checklist:

  • I have posted the link for the PR in the usrse slack (#website) to ask for reviewers
  • I have previewed changes locally
  • I have updated the README.md if necessary

cc @usrse-maintainers

@rafmudaf
Copy link
Contributor Author

rafmudaf commented Aug 9, 2022

@danielskatz
Copy link
Contributor

👋 @sandragesing @mmshad @jordanperr @roelofsaj - can one or more of you review this?

@jordanperr
Copy link
Contributor

I was an author on this post but I am happy to review it too.

@jordanperr
Copy link
Contributor

Looks like the urlcheck is failing for three job postings, should I remove those from the jobs page in this PR?

@danielskatz
Copy link
Contributor

They are no longer on the website but we're when this PR was created.

@rafmudaf
Copy link
Contributor Author

I'll rebase the branch to fix it

@rafmudaf
Copy link
Contributor Author

@danielskatz could you please approve the workflows again?

@danielskatz
Copy link
Contributor

Once at least one person reviews this, we can merge it. Ideally someone who is not an author, though author comments are welcome too

@mmshad
Copy link
Contributor

mmshad commented Aug 18, 2022

@rafmudaf , do you want to add "#" for the Slack channel names on the last table to be consistent with the rest of doc.

@jordanperr
Copy link
Contributor

I approve of the post. However, I agree it would be preferable to get comments from someone who is not an author. Some last minute remarks from me:

  • The screenshot of the map contains your bookmarks bar. Nothing too bad in there, but it may be preferable to re-create it with the bookmarks bar hidden.
  • Update the first reference of "front range" to be clear that this is a geographical region in Colorado.
  • Conceptually, the inclusion of the regional groups on the map could be separate heading like "###Regional Groups added to Map" - but I don't have a strong opinion here.

All of these are small and do not impact my approval.

@rafmudaf
Copy link
Contributor Author

The screenshot of the map contains your bookmarks bar. Nothing too bad in there, but it may be preferable to re-create it with the bookmarks bar hidden.

Oh whoops! In another version I had blocked out my bookmarks. Good catch, I'll update that. No one wants to see what I'm reading.

@rafmudaf
Copy link
Contributor Author

@mmshad I had added it to some but missed a few. Thanks for catching that, it's fixed. Let me know if you see any others that I've missed.

@cosden
Copy link
Member

cosden commented Aug 20, 2022

Here's the preview. I think everything looks good except for the image which I've suggested a fix above.
https://output.circle-artifacts.com/output/job/7a851ea3-09ac-4ddc-b92f-fc71a775e775/artifacts/0/usrse.github.io/2022-08-04-local-regional-working-group/index.html

Co-authored-by: Ian Cosden <cosden@users.noreply.github.com>
@danielskatz
Copy link
Contributor

let's see how that change works

@danielskatz
Copy link
Contributor

I'm going to go ahead and merge this

@danielskatz danielskatz merged commit 861ec65 into USRSE:main Aug 20, 2022
@rafmudaf
Copy link
Contributor Author

rafmudaf commented Sep 7, 2022

Thanks for getting this through while I was away @cosden @danielskatz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants