Upgrade veda UI to 5.12.3 and update env variable for page footer #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sandesh-sp
commented
Feb 10, 2025
•
sandesh-sp
commented
- Upgrade veda ui to 5.12.3
- Create env variable ENABLE_USWDS_PAGE_FOOTER and set it to 'FALSE'
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@hanbyul-here @sandrahoang686 we're seeing an issue on this PR where the footer still displays on the E&A page. Did the GHG team configure something wrong here or is this potentially a bug with our recent footer work? |
paridhi-parajuli
approved these changes
Feb 10, 2025
sandesh-sp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.