[DO NOT MERGE] [PREVIEW] Change veda-ui to point to "1393-card-component-refactor-spike" #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
3 tasks
sandrahoang686
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Feb 3, 2025
…le (#1407) **Related Ticket:** #1393 ### Description of Changes _**NOTE:** Changes are backwards compatible_ These changes are meant to break out the current different cards types into their own explicit components/files. This way we could easily scale to add new cards types that have been introduced for the template instance. This lays the foundation and pattern in the code base so we can have an easier jump start when implementing the new USWDS card types. The controller file is kept (index.tsx) because this is how legacy code uses the current card component but we can continue to use this controller file for the new architecture orrr instances could just explicitly import the card type they want to use. These current cards types will be obsolete for the template instance as we move towards USWDS but because they are broken out in this PR, it will be easy to add the new cards types and remove deprecated ones later. I'm thinking ideally when we add the new CardTypes that use USWDS and Sass instead of styled components, we should structure the file directories like so... ``` - card - classic - index.tsx - styles.scss - cover - index.tsx - styles.scss index.tsx ``` I didn't organize it like this in this PR because there was no need since currently we are still using styled components. ### Notes & Questions About Changes **GHG PREVIEW** US-GHG-Center/veda-config-ghg#709 **EIC PREVIEW** NASA-IMPACT/veda-config-eic#164 ### Validation / Testing **Changes should be backwards compatible** - [ ] Validate that all cards work and look as expected in veda-ui deploy preview - [ ] Validate that all cards work and look as expected in GHG preview linked above - [ ] Validate that all cards work and look as expected in EIC preview linked above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you creating this Pull Request?