Skip to content

Commit

Permalink
fix(mobile-app): adjust search button and map display in kyh page (#339)
Browse files Browse the repository at this point in the history
* Added github actions workflow for aut deployment to .72 server.

* Added github action for S3 deployment.

* Changed to staging. Created branch for staging.

* Retrigger deployment workflow.

* fix(studio): zoom in on ios (#192)

# Summary 

- Fixes #186
- The `load` event isn't firing on NOAH Studio. As such, the `centerListener()` method isn't called which is responsible for the zooming in to the selected place. However, `style.load` do get called. The fix implemented here is to also use the event `style.load` to call the methods that were previously called by upon the firing of the `load` event but only listen to `style.load` once.
  - We need to further investigate **why** `load` doesn't work on Studio in iOS but works in KYH
- Confirming that only the NOAH Studio is affected by this issue.
 
# Demo

![Kapture 2021-10-05 at 22 49 45](https://user-images.githubusercontent.com/11599005/136047077-d0da7a85-9157-4d01-bae9-07a6039fd9c1.gif)

* ci(netlify): add _redirects file

* S3 Deployment Validation (#198)

* Added if condition to run workflow only on successful PR merge. (#195)

* Checking proper automation workflow. Will revert this small change upon validation. (#196)

* Change deployment trigger. Revert small biblio change. (#199)

* Checking proper automation workflow. Will revert this small change upon validation.

* Changed trigger for deployment workflow. Revert small change to bibliography.

* Cascade dev changes on workflow to prod (#202)

* Added AWS deployment workflow

* noah mobile app search bar flot to map

* improve display of the map it is more bigger

* changed default center from malacanang to UPRI office

---------

Co-authored-by: pfgoting <pfgoting@gmail.com>
Co-authored-by: Jadurani Davalos <jadurani.davalos@gmail.com>
Co-authored-by: kennethbeoliporada <kennethbeoliporada@gmail.com>
  • Loading branch information
4 people authored Aug 23, 2023
1 parent 1fe0aeb commit 0f9dd3e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<noah-search
[searchTerm]="currentLocation$ | async"
(selectPlace)="selectPlace($event)"
class="px-6 md:px-8 w-full mt-4 block relative"
class="px-12 md:px-8 w-full md:mt-4 block md:relative absolute top-0"
>
</noah-search>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="flex flex-col md:flex-row h-screen w-screen">
<noah-map-kyh class="relative h-4/6 md:h-full w-full"></noah-map-kyh>

<div class="bg-gray-50 shadow-md overflow-auto h-2/3 md:h-full md:w-136">
<div class="bg-gray-50 shadow-md overflow-auto h-2/4 md:h-full md:w-136">
<router-outlet></router-outlet>
</div>
</div>
6 changes: 3 additions & 3 deletions src/app/features/know-your-hazards/store/kyh.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ import { Injectable } from '@angular/core';
import { StoreService } from '@core/services/store-service.service';

/**
* Malacañang palace
* UPRI OFFICE
*/
export const PH_DEFAULT_CENTER = {
lat: 14.594112104824488,
lng: 120.9943811923392,
lat: 14.6577006,
lng: 121.0709613,
};

export type HazardType = 'flood' | 'landslide' | 'storm-surge';
Expand Down

0 comments on commit 0f9dd3e

Please sign in to comment.