Added Durability Bonus Prop #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to go |
|
Like the artifact rarity (#280), this exposes the stuff to JS via Item, but it is added to the Base Object - this makes more sense to hang off cItem instead, as it doesn't have a conceptual value for a character |
strattond
requested changes
Jan 16, 2025
source/cItem.cpp
Outdated
| void CItem::SetDurabilityHpBonus(SI16 newValue) | ||
| { | ||
| durabilityHpBonus = newValue; | ||
| if (CanBeObjType(OT_ITEM)) |
There was a problem hiding this comment.
Given this only applies to Items (i.e. CanBeObjType(OT_ITEM) is always true), you can probably remove the IF directly and just call UpdateRegion().
You also shouldn't need to do a static cast, as you're already in CItem at this point.
So this whole if could be reduced to, hopefully, UpdateRegion();
There was a problem hiding this comment.
okay will update
strattond
approved these changes
Jan 16, 2025
strattond
added
the
nomerge - future ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.