Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce image size in test folder #86

Open
ebgoldstein opened this issue Feb 11, 2020 · 1 comment
Open

reduce image size in test folder #86

ebgoldstein opened this issue Feb 11, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ebgoldstein
Copy link
Contributor

ebgoldstein commented Feb 11, 2020

Try reducing the size data in the tests folder. Do you really need to include the full resolution images to test on? Or is it possible to use a reduced size image or even mock them out completely. This might improve compatibility with build systems (which can have issues if the repo is too big) and might just generally be easier to work with.

from @chrisleaman 's JOSS review: openjournals/joss-reviews#2075 (comment)

@ebgoldstein ebgoldstein added the enhancement New feature or request label Feb 11, 2020
@Matmorcat
Copy link
Contributor

Yes. Some of the earlier tests were fairly inefficient, and I'd like to rewrite many of them as mocking out the actual accessing of web content and files would make the tests much more robust and reliable. For the current tests, the images can actually just be near-empty files, so long as the tests that check file sizes are updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants