You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Try reducing the size data in the tests folder. Do you really need to include the full resolution images to test on? Or is it possible to use a reduced size image or even mock them out completely. This might improve compatibility with build systems (which can have issues if the repo is too big) and might just generally be easier to work with.
Yes. Some of the earlier tests were fairly inefficient, and I'd like to rewrite many of them as mocking out the actual accessing of web content and files would make the tests much more robust and reliable. For the current tests, the images can actually just be near-empty files, so long as the tests that check file sizes are updated as well.
from @chrisleaman 's JOSS review: openjournals/joss-reviews#2075 (comment)
The text was updated successfully, but these errors were encountered: