Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 to tests; remove lint #41

Merged
merged 17 commits into from
Feb 26, 2024

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Feb 20, 2024

This pull requests adds Python 3.12 (and removes 3.8, 3.9) to the CI tests, updates the linter versions, and removes a bunch of lint.

I've removed the lint workflow and instead use pre-commit.ci to check for lint. pre-commit.ci will not only check for lint but also, where possible, fix the lint errors. I hope this will make things a little easier. You can and should still run nox -s lint locally but pre-commit.ci will help when you forget.

@mcflugen
Copy link
Member Author

@anardek This is ready to go. If you could give it a quick look, that would be great!

@anardek
Copy link
Member

anardek commented Feb 26, 2024

This looks great. Just making sure: we already published V1 on conda (with the old python version), and this pull request updates the main branch to be compatible with python 3.12. So now I need to conda again?

@mcflugen
Copy link
Member Author

mcflugen commented Feb 26, 2024

Yes, v1 is already on conda-forge—and is available for all version of Python >= 3.10 (including 3.12). All I've done here is added Python 3.12 to the versions of Python that cascade is tested against. Because all the tests passed with Python 3.12, there's no need to conda again. If it had turned out that Python 3.12 caused things to break, we would have had to fix things and re-conda but that wasn't the case, so we're all good.

@mcflugen mcflugen merged commit 397f84c into UNC-CECL:main Feb 26, 2024
10 checks passed
@mcflugen mcflugen deleted the mcflugen/add-python-312 branch February 26, 2024 21:30
@mcflugen mcflugen mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants