-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalize our use of unsubscribe()
#1022
Comments
Upon further discussion, this probably doesn't apply to Lab 2 at all, so Nic moved this to the Lab 3 repo. |
If we like what's present in this PR, we should be sure to also make the change here. I have the impression there may be more to this, but it's worth noting that it was looked at in the iteration template. |
The usage of subscribe we had here is deprecated. Also, update to match the iteration template for consistency. Relates to #1022
There is a PR and branch in Lab 4 that does some/most things related to this: UMM-CSci-3601/3601-lab4-mongo#68 |
We don't appear to use this at all in Labs 2 and 3, but we do have it in Lab 4 and the iteration template. In reading the Internet on this, it feels like we might find it useful to use
take(1)
orfirst()
in all this, but I'm not really sure what the best practices here are.See this issue in the iteration template for more.
The text was updated successfully, but these errors were encountered: