Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize our use of unsubscribe() #1022

Open
NicMcPhee opened this issue Feb 20, 2022 · 3 comments
Open

Rationalize our use of unsubscribe() #1022

NicMcPhee opened this issue Feb 20, 2022 · 3 comments

Comments

@NicMcPhee
Copy link
Member

NicMcPhee commented Feb 20, 2022

We don't appear to use this at all in Labs 2 and 3, but we do have it in Lab 4 and the iteration template. In reading the Internet on this, it feels like we might find it useful to use take(1) or first() in all this, but I'm not really sure what the best practices here are.

See this issue in the iteration template for more.

@NicMcPhee NicMcPhee transferred this issue from UMM-CSci-3601/3601-lab2_client-server Jan 20, 2023
@kklamberty
Copy link
Member

Upon further discussion, this probably doesn't apply to Lab 2 at all, so Nic moved this to the Lab 3 repo.

@kklamberty
Copy link
Member

If we like what's present in this PR, we should be sure to also make the change here. I have the impression there may be more to this, but it's worth noting that it was looked at in the iteration template.

kklamberty added a commit that referenced this issue Feb 11, 2023
The usage of subscribe we had here is deprecated. Also, update to match the iteration template for consistency. Relates to #1022
@kklamberty
Copy link
Member

There is a PR and branch in Lab 4 that does some/most things related to this: UMM-CSci-3601/3601-lab4-mongo#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants