Sunt05/issue355 #364
Merged
Sunt05/issue355 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunt05
commented
Feb 6, 2025
sunt05
commented
- Added verbose mode to pytest command
- Enabled short traceback format for clearer error output
- Configured coverage reporting for supy package
- Display coverage report with missing line details
- Add Enum to all method options in ModelPhysics
- Implemented a new test method to verify SUEWS configuration conversion between YAML and DataFrame formats - Checks preservation of key configuration attributes during conversion - Ensures DataFrame conversion maintains the original configuration structure
- Implemented comprehensive data model classes for SUEWS configuration and state management - Created base classes for handling references, values with DOI, and surface types - Developed models for physics settings, profiles, surface properties, and model states - Included support for converting between YAML, DataFrame, and object representations - Added validation and conversion methods for different surface types (urban, vegetation, water)
Minor cleanup of unnecessary import from site module in surface.py
- Moved `init_df_state` from `state.py` to `type.py` - Added `from_yaml` class method to `SUEWSConfig` in `core.py` - Updated imports in multiple data model modules - Added new utility function `init_config_from_yaml` in `_config.py` - Installed new data model files `hydro.py` and `ohm.py`
…on tests - Added unit tests for AnthropogenicEmissions data model conversion - Implemented validation tests for Model physics settings - Added tests for Site properties latitude validation - Created tests for InitialStates snow albedo validation - Expanded multi-site configuration testing - Updated imports in test_data_model.py to support new data model classes
- Removed redundant AnthropogenicEmissions test - Simplified Site and InitialStates validation tests - Updated test methods to directly validate model properties - Improved error checking and property validation in test cases
- Introduced multiple new enum classes to represent different model physics methods - Updated ModelPhysics class to use strongly typed enums for configuration settings - Added YAML representation for all new enum classes - Improved type safety and clarity in model configuration options - Expanded documentation for enum conversion to YAML
- Added verbose mode to pytest command - Enabled short traceback format for clearer error output - Configured coverage reporting for supy package - Display coverage report with missing line details
|
Address #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.