fix mypy 1.12 typing issues

UKGovernmentBEIS · Oct 14, 2024 · 57a6719 · 57a6719
1 parent 65364ff
commit 57a6719
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/inspect_ai/dataset/_dataset.py b/src/inspect_ai/dataset/_dataset.py
@@ -5,7 +5,6 @@
     Any,
     Callable,
     Iterator,
-    Optional,
     Sequence,
     Union,
     overload,
@@ -128,7 +127,7 @@ def shuffle(self, seed: int | None = None) -> None:
     def sort(
         self,
         reverse: bool = False,
-        key: Optional[Callable[[Sample], "SupportsRichComparison"]] = sample_input_len,
+        key: Callable[[Sample], "SupportsRichComparison"] = sample_input_len,
     ) -> None:
         """Sort the dataset (in place) in ascending order and return None.
 
@@ -278,7 +277,7 @@ def shuffle(self, seed: int | None = None) -> None:
     def sort(
         self,
         reverse: bool = False,
-        key: Optional[Callable[[Sample], "SupportsRichComparison"]] = sample_input_len,
+        key: Callable[[Sample], "SupportsRichComparison"] = sample_input_len,
     ) -> None:
         self.samples.sort(reverse=reverse, key=key)
 

diff --git a/src/inspect_ai/model/_call_tools.py b/src/inspect_ai/model/_call_tools.py
@@ -380,7 +380,7 @@ def tool_param(type_hint: Type[Any], input: Any) -> Any:
             dataclass_data: dict[str, Any] = {}
             fields = type_hint.__dataclass_fields__  # type: ignore
             for name, field in fields.items():
-                dataclass_data[name] = tool_param(field.type, input.get(name))
+                dataclass_data[name] = tool_param(field.type, input.get(name))  # type: ignore
             return type_hint(**dataclass_data)
         elif issubclass(type_hint, BaseModel):
             return type_hint(**input)

diff --git a/src/inspect_ai/tool/_tool_info.py b/src/inspect_ai/tool/_tool_info.py
@@ -181,7 +181,7 @@ def parse_object(cls: Type[Any]) -> ToolParam:
     if is_dataclass(cls):
         fields = cls.__dataclass_fields__  # type: ignore
         for name, field in fields.items():
-            properties[name] = parse_type(field.type)
+            properties[name] = parse_type(field.type)  # type: ignore
             if field.default == field.default_factory:
                 required.append(name)
     elif isinstance(cls, type) and issubclass(cls, BaseModel):