Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bottom padding in minimalist-ios-tapbar theme #1604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mxilievski
Copy link
Contributor

@mxilievski mxilievski commented Jan 23, 2025

Fixing this again :)

The selector div#view doesn't exist anymore. I have put it's code directly in the #view selector. Additionally I have made sure that there is no other dom element with the #view id. Therefore I believe this change is safe and it should not cause any troubles other then fixing the issue. I have tested this code change and it works just fine on my setup.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

@guger
Copy link

guger commented Jan 30, 2025

I've tried to add your changes to my theme file, but I don't think it changed anything 🤔 any advice?

@mxilievski
Copy link
Contributor Author

I've tried to add your changes to my theme file, but I don't think it changed anything 🤔 any advice?

You need to reload the themes using action frontend.reload_themes

@guger
Copy link

guger commented Jan 31, 2025

@mxilievski Thank you, it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Tapbar/Mobile Tapbar overlay bottom content
2 participants