Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR AVAILABLE] custom_card_mpse_printer/custom_card_bar_card/custom_card_sisimomo_printer not compatible with card_mod v3.4.0+ #1435

Closed
tieskuh opened this issue Jan 1, 2024 · 5 comments · Fixed by #1432, #1437 or #1438
Labels

Comments

@tieskuh
Copy link
Contributor

tieskuh commented Jan 1, 2024

Describe the bug
Card mod has a breaking change in v3.4.0: https://github.com/thomasloven/lovelace-card-mod/releases/tag/v3.4.0
custom_card_mpse_printer didn't implement that yet.

To Reproduce
Style is not applied, card doesn't look like it should.

Screenshots
image

Fix for the issue
#1432

@Luke15153
Copy link

This problem affects at least these two cards too:

  • custom_cards/custom_card_bar_card
  • custom_cards/custom_card_sisimomo_printer

Same solution, just add card_mod: as parent of style:

@Liionboy
Copy link

Liionboy commented Jan 4, 2024

Problem is with all card with bar:

image

@tieskuh
Copy link
Contributor Author

tieskuh commented Jan 5, 2024

Fix for custom_cards/custom_card_bar_card:
#1437

Fix for custom_cards/custom_card_sisimomo_printer
#1438

@Liionboy Which card is that?

@tieskuh tieskuh changed the title custom_card_mpse_printer not compatible with card_mod v3.4.0+ custom_card_mpse_printer/custom_card_bar_card/custom_card_sisimomo_printer not compatible with card_mod v3.4.0+ Jan 5, 2024
@Liionboy
Copy link

Liionboy commented Jan 6, 2024

Is custom_card_bar_card

@tieskuh tieskuh changed the title custom_card_mpse_printer/custom_card_bar_card/custom_card_sisimomo_printer not compatible with card_mod v3.4.0+ [PR AVAILABLE] custom_card_mpse_printer/custom_card_bar_card/custom_card_sisimomo_printer not compatible with card_mod v3.4.0+ Jan 30, 2024
@tieskuh
Copy link
Contributor Author

tieskuh commented Feb 5, 2024

Not much going on in the minimalist github....
If you are still facing the problem, the easiest way is to revert to card-mod 3.3.1 via HACS until the PR is approved.

image

basbruss added a commit that referenced this issue Jul 3, 2024
[FIX FOR #1435] custom_card_sisimomo_printer.yaml - Fix for card-mod v3.4.0
basbruss added a commit that referenced this issue Jul 3, 2024
[FIX FOR #1435] custom_card_bar_card.yaml  - Fix for card-mod v3.4.0
basbruss added a commit that referenced this issue Jul 3, 2024
[FIX FOR #1435] custom_card_mpse_printer.yaml - Fix for card-mod v3.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment