Duo Universal Login Script Support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ewang2002
commented
Apr 13, 2024
ewang2002
commented
- Adds support for the new Duo universal login prompt that was released on March 26.
- Removes support for Duo SMS login: Duo universal login prompt sends 1 SMS code instead of 10 SMS codes that are used one after another, which makes it obsolete.
mr4tt
reviewed
Apr 13, 2024
| return; | ||
| } | ||
|
|
||
| if (!(await duoFrame.$("#remember_me_label_text"))) { | ||
| // "Other Options" selector | ||
| if (!(await page.$("#auth-view-wrapper > div:nth-child(2) > div.row.display-flex.other-options-link.align-flex-justify-content-center.size-margin-bottom-large.size-margin-top-small > a"))) { |
mr4tt
approved these changes
Apr 13, 2024
mr4tt
reviewed
Apr 13, 2024
|
|
||
| Keep in mind that you'll need to restart the login script setup process every 6-7 days to ensure you can still keep | ||
| yourself logged in. | ||
|
|
||
| ~~Also, Ruby is a clown~~ |
There was a problem hiding this comment.
I will take this as a "LGTM"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.