Persist light theme on refresh #513
Conversation
samcunliffe
added
bug
There was a problem hiding this comment.
I think on balance having a few lines extra JS for a more functional site in the interim is worth the tradeoff, but agree it seems that using an alternative solution for building the site like Material for MkDocs which support this out of the box would be good.
When serving this locally and viewing in Firefox the theme still does not seem to persist between page changes, which from adding some console.log statements seems to be as the "DOMContentLoaded" event listener never gets called. As far as I can tell (my JavaScript knowledge is very minimal though!) the syntax for adding the event listener is all correct, so I am not sure if this is just something specific about serving this locally?
This comment was marked as outdated.
This comment was marked as outdated.
|
Now working for me... Screen.Recording.2025-02-03.at.15.17.38.mov |
Python is cool. Javascript is not cool. |
|
➕ for moving to https://squidfunk.github.io/mkdocs-material as well |
Fixes
... using the workaround suggested in
Worth spending a bit of thought on whether we want more lines of my hacky JS code saving the theme to local storage, which we potentially can't delete until jtd/#1223 is solved nicely upstream.
Question:
Is it worth switching build system to something that supports theme toggling and inferring theme from the browser/os settings? It feels like it's the responsibility of the doc engine/doc theme. E.g. Material for MkDocs supports it.
That said, if you're happy with these lines, I am.