Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readthedocs updating #290

Open
dave-doty opened this issue Dec 20, 2023 · 4 comments · Fixed by #293
Open

fix readthedocs updating #290

dave-doty opened this issue Dec 20, 2023 · 4 comments · Fixed by #293
Assignees
Labels
bug Something isn't working closed in dev high priority Something cruicial to get working soon.

Comments

@dave-doty
Copy link
Member

dave-doty commented Dec 20, 2023

readthedocs is having errors even though I can compile with Sphinx locally: https://readthedocs.org/projects/scadnano-python-package/builds/22907418/

@dave-doty dave-doty added the bug Something isn't working label Dec 20, 2023
@dave-doty dave-doty added the high priority Something cruicial to get working soon. label Dec 20, 2023
@rayzhuca
Copy link
Member

I think this is due to the new changes that buildthedocs rolled out:
https://blog.readthedocs.com/use-build-os-config/
I'll create a new branch that adds the new configs in readthedocs.yml.

@dave-doty
Copy link
Member Author

dave-doty commented Dec 21, 2023

Here's the latest error (after fixing the build.os issue in PR #292): https://readthedocs.org/projects/scadnano-python-package/builds/22917882/

image

@rayzhuca rayzhuca linked a pull request Dec 21, 2023 that will close this issue
@rayzhuca
Copy link
Member

Merged #296 and dev built successfully https://readthedocs.org/projects/scadnano-python-package/builds/23148921/.

@dave-doty
Copy link
Member Author

In general we only close issues when they make it to the main branch (that's the main reason to have main be the default branch, so that commit messages with phrases such as "closes #<issue_number>" will automatically close them, but only when that commit makes it to the main branch), but maybe because this involves readthedocs it is already fixed? Essentially let's leave this open until we've fixed the issue totally (i.e., the readthedocs site shows the correct documentation), but I haven't checked to see if it's really fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed in dev high priority Something cruicial to get working soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants