Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent wording #185

Open
dennmuel opened this issue Jul 24, 2020 · 0 comments
Open

Inconsistent wording #185

dennmuel opened this issue Jul 24, 2020 · 0 comments

Comments

@dennmuel
Copy link
Member

dennmuel commented Jul 24, 2020

Maybe more of a "note to self" than an actual issue: Working on other topics I noticed that the naming of variables concerning window and section management is a bit inconsistent.

Coming from the database perspective there is

  • the primary key of a window, called id in the database
  • the win_id (hex value used for the system-side window commands)
  • the current quadrant of a window on the palma screen, referred to as section in the db, but as $_REQUEST['window'] and $windownumber in control.php

Also there's a function called NextID which actually returns the next free section: https://github.com/UB-Mannheim/PalMA/blob/master/DBConnector.class.php#L91-L113

There's also some $window and $w arrays for windows to be created which is okay, but then there's also this $window which seems to be used to create the win_id: https://github.com/UB-Mannheim/PalMA/blob/master/control.php#L376-L387

There is no malfunction here, but maybe some consistent naming would improve code readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant