Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with update checker disabled #305

Closed
wants to merge 2 commits into from

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jan 22, 2025

You can reproduce the issue with

meson setup build -Db_pch=false -Dwerror=false -Dbuildtype=plain -Denable_update_checker=false -Dffms2=enabled -Dsystem_luajit=true -Dalsa=enabled -Dfftw3=enabled -Dopenal=disabled -Dportaudio=disabled -Dlibpulse=enabled -Dhunspell=enabled -Duchardet=enabled  --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc

Meson defines the DEFINE to 0 but the check assumes it will not be defined if disabled.

I'm not sure how this wasn't hit before, maybe nobody disables the update checker.

@sarnex sarnex marked this pull request as ready for review January 22, 2025 10:44
@sarnex sarnex marked this pull request as draft January 22, 2025 11:40
Signed-off-by: Nick Sarnie <sarnex@gentoo.org>
@arch1t3cht
Copy link
Member

This was a bug in the meson logic to turn a configuration_data into a set of compiler flags. I fixed this on the meson side in 0f2c324 .

@arch1t3cht arch1t3cht closed this Jan 22, 2025
@sarnex
Copy link
Contributor Author

sarnex commented Jan 22, 2025

Thanks, I assumed the logic there was right so I didn't even look :)

Glad I don't have to fight the preprocessor anymore

@sarnex sarnex deleted the update branch January 22, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants