Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI #2674 Adapt unit tests to run on Linux #2690

Merged
merged 26 commits into from
Jan 7, 2025
Merged

WI #2674 Adapt unit tests to run on Linux #2690

merged 26 commits into from
Jan 7, 2025

Conversation

fm-117
Copy link
Contributor

@fm-117 fm-117 commented Dec 30, 2024 •
edited
Loading

Ignore work item used in commits. Apparently it is not required to have a special process for \r. Instead, some adaptations have been done through the tests to make them run on Linux.

Contents

This PR is mainly a collection of fixes on unit tests to run properly on Linux platform. However some functional changes have been made to avoid altering all tests:

  • Codegen bug fix on node positions for generated node inserted after another node
  • DOT graph output in cfg/dfa notifications does no longer include line breaks
  • Formalized comments returned by LanguageServer are no longer formatted using line breaks from source code, clients must apply their own formatting depending on their display constraints
  • Same goes for Hover data: tooltip texts are on a single line now
  • LSR tests involving code generation (i.e. refactorings) have been duplicated between Windows and non-Windows as the generated code will always use the platform-specific line break sequence

fm-117 added 17 commits December 5, 2024 15:27
@fm-117
WI #2684 Fix some unit test errors
5d6b91c
@fm-117
WI #2684 Use unified line comparison method
32fc3fe
@fm-117
WI #2684 Fix documentation tests
5452201
@fm-117
WI #2684 Fix file name case - part1
b475b3e
@fm-117
WI #2684 Fix file name case - part2
1095e70
@fm-117
WI #2684 Normalize line ending translation when generating dot files
58d55e3
@fm-117
WI #2684 Fix test paths
38d8efc
@fm-117
WI #2684 Avoid generating newlines in CFG/DFA notification
8972f9f
@fm-117
WI #2684 Fix refactoring processor test when reading test data file
a1f6d2a
@fm-117
WI #2684 Duplicate LSR tests for AdjustFillers depending on platform
4c29961
@fm-117
WI #2684 Remove newlines from hover tooltips
b83f7e4
@fm-117
WI #2684 Disable file watchers for LSR tests
ae56bec
@fm-117
WI #2684 Fix local directory library file enumeration
26ce14d
@fm-117
WI #2684 Fix inserted node position in Codegen
5b037b9
@fm-117
WI #2684 Fix case in LSR test folder name
237a5ff
@fm-117
WI #2684 Force file order when testing multiple files at once
e11829b
@fm-117
WI #2684 Add matrix strategy to build on multiple OSes
ba14890
@fm-117 fm-117 self-assigned this Dec 30, 2024
@fm-117 fm-117 linked an issue Dec 30, 2024 that may be closed by this pull request
Ignore carriage-return character when comparing test results #2684
Closed
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 30, 2024
@fm-117 fm-117 requested a review from efr15 December 30, 2024 10:45
@fm-117 fm-117 marked this pull request as ready for review December 30, 2024 10:45
@fm-117 fm-117 changed the title WI #2674 Adapt unit test to run on Linux WI #2674 Adapt unit tests to run on Linux Dec 30, 2024
@fm-117 fm-117 mentioned this pull request Dec 31, 2024
Merged
efr15
efr15 requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@efr15 efr15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of modifications in this PR including functional changes, technical improvements and so on. It's not easy to see all the impacts. Let's trust the automated tests...

Codegen/src/Generators/LinearNodeSourceCodeMapper.cs Outdated Show resolved Hide resolved
TypeCobol.Analysis/Graph/CfgDotFileForNodeGenerator.cs Outdated Show resolved Hide resolved
...NoWindows_ExecuteCommandRefactorAdjustFillers/input/ExecuteCommandRefactorAdjustFillers.tlsp Show resolved Hide resolved
TypeCobol.Test/TestUtils.cs Show resolved Hide resolved
@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 3, 2025
fm-117 added 2 commits January 6, 2025 09:54
@fm-117
Merge branch 'develop' into 2684-ignore-carriage-return-character-whe…
4b33340 
…n-comparing-test-results

# Conflicts:
#	TypeCobol.LanguageServer.Test/ProcessorTests/DataLayoutProcessorCSVTest.cs
#	TypeCobol.LanguageServer.Test/RefactoringTests/RefactoringProcessorTest.cs
@fm-117
WI #2684 Code review
df4ef58
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 6, 2025
@fm-117 fm-117 requested a review from efr15 January 6, 2025 10:12
@trafico-bot trafico-bot bot removed the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label Jan 6, 2025
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 7, 2025
@fm-117 fm-117 merged commit 1a19ef4 into develop Jan 7, 2025
8 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jan 7, 2025
@fm-117 fm-117 deleted the 2684-ignore-carriage-return-character-when-comparing-test-results branch January 7, 2025 10:12
@fm-117 fm-117 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efr15 efr15 efr15 approved these changes

Assignees

@fm-117 fm-117

Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore carriage-return character when comparing test results
2 participants
@fm-117 @efr15