WI #2600 Fix NullReferenceException in Workspace.CollectDataLayoutNodes #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm-117
reviewed
Dec 19, 2023
| @@ -1100,7 +1100,7 @@ static object GetEnd(long start, long length) | |||
| private List<Tuple<int, DataDefinition, int>> CollectDataLayoutNodes(CompilationUnit compilationUnit) | |||
| { | |||
| var dataLayoutNodes = new List<Tuple<int, DataDefinition, int>>(); | |||
| Node dataDivision = compilationUnit.TemporaryProgramClassDocumentSnapshot.Root.MainProgram.GetChildren<DataDivision>().FirstOrDefault(); | |||
| Node dataDivision = compilationUnit?.TemporaryProgramClassDocumentSnapshot?.Root?.MainProgram?.GetChildren<DataDivision>()?.FirstOrDefault(); | |||
There was a problem hiding this comment.
compilationUnit, Root and the result of GetChildren<> cannot be null. TemporaryProgramClassDocumentSnapshot should not be null either as we force node rebuilding.
I'm ok to keep it like this safe approach but this will be changed if we move forward with the #nullable contexts.
fm-117
approved these changes
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
To reproduce the crash in a Cobol program: remove the . after IDENTIFICATION DIVISION