You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
datamapplot.create_interactive_plot() writes a bunch of .zip files with data in them when inline_data is False, and the location to put them is modified only by offline_data_prefix ( eventually file_prefix). Using this to modify the directory location is hacky...for example, it gets called as gzip.open("{file_prefix}_point_data_{i}.zip"). This is ok (if not ideal) in some contexts, but is fragile and awkward if I want to put the data somewhere else entirely.
At a minimum, I'd suggest using a separate parameter to control the directory of the offline data that defaults to the current working directory.
As an additional thought, the .save on InteractiveFigure saves the html version of the figure to the filename parameter. It would be better if there was a more consistent way to save artifacts related to interactive figures. It's easy to save the html and the data required for it in completely different locations when using inline_data False and not bundling.
I can sort of understand why things are this way at the moment but I think a cleaner and more transparent way to save off the artifacts would be useful. I'm happy to help with sorting out what the desired behaviour might be and then implementing a PR for the changes. Just let me know.
The text was updated successfully, but these errors were encountered:
The file_prefix was certainly never really meant for specifying a directory path, so yes, adding an option for that would be useful. In general the whole nature of things kind of grew organically, so if you want to take a pass at refactoring where things have ended up into something a little saner and more maintainable that would be greatly appreciated.
datamapplot.create_interactive_plot()
writes a bunch of.zip
files with data in them wheninline_data
is False, and the location to put them is modified only byoffline_data_prefix
( eventuallyfile_prefix
). Using this to modify the directory location is hacky...for example, it gets called asgzip.open("{file_prefix}_point_data_{i}.zip")
. This is ok (if not ideal) in some contexts, but is fragile and awkward if I want to put the data somewhere else entirely.At a minimum, I'd suggest using a separate parameter to control the directory of the offline data that defaults to the current working directory.
As an additional thought, the
.save
onInteractiveFigure
saves the html version of the figure to thefilename
parameter. It would be better if there was a more consistent way to save artifacts related to interactive figures. It's easy to save the html and the data required for it in completely different locations when using inline_data False and not bundling.I can sort of understand why things are this way at the moment but I think a cleaner and more transparent way to save off the artifacts would be useful. I'm happy to help with sorting out what the desired behaviour might be and then implementing a PR for the changes. Just let me know.
The text was updated successfully, but these errors were encountered: