Skip to content

Commit

Permalink
Update API level to target Android 14 (API level 34).
Browse files Browse the repository at this point in the history
Signed-off-by: Dmytro Turskyi <dmytro.turskyi@gmail.com>
  • Loading branch information
Turskyi committed Jul 20, 2024
1 parent 0acec43 commit 8fd369b
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v2.3.3

- name: Set up JDK environment(JDK 11)
- name: Set up JDK environment(JDK 17)
uses: actions/setup-java@v1.4.3
with:
java-version: 17
Expand Down
33 changes: 21 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
[![Stand With Ukraine](https://raw.githubusercontent.com/vshymanskyy/StandWithUkraine/main/banner-direct-single.svg)](https://stand-with-ukraine.pp.ua)
[![Build status](https://build.appcenter.ms/v0.1/apps/6ef58ca2-721c-4622-bfe7-336d4c6d7d01/branches/master/badge)](https://appcenter.ms)
[![Upload to Firebase App Distribution](https://github.com/Turskyi/Travelling/actions/workflows/android_ci.yml/badge.svg?branch=dev&event=push)](https://github.com/Turskyi/Travelling/actions/workflows/android_ci.yml)
<img alt="GitHub commit activity" src="https://img.shields.io/github/commit-activity/m/Turskyi/travelling">

# Travelling [![Build status](https://build.appcenter.ms/v0.1/apps/6ef58ca2-721c-4622-bfe7-336d4c6d7d01/branches/master/badge)](https://appcenter.ms)
# Travelling

An Android mobile application, which gives a convenient way to collect all countries that you have
visited.
Expand Down Expand Up @@ -73,18 +76,24 @@ app bundle to **Google Play** after every push to **master** branch;
</br>

• Screenshots:

<img src="screenshots/device-2020-06-05-085243.png" width="200" >
<img src="screenshots/device-2020-06-05-085456.png" width="200" >
<img src="screenshots/device-2020-06-05-090524.png" width="200" >
<img src="screenshots/device-2020-06-28-164528.png" width="300" >
<img src="screenshots/device-2020-10-18-103522.png" width="200" >
<img src="screenshots/device-2020-10-18-103111.png" width="200" >
<img src="screenshots/device-2020-06-05-090129.png" width="200" >
<img src="screenshots/device-2020-06-05-091508.png" width="200" >
<img src="screenshots/device-2020-06-05-094730.png" width="300" >
<img src="screenshots/device-2020-06-28-162902.png" width="400" >
<!--suppress CheckImageSize -->
<img src="screenshots/device-2020-06-05-085243.png" width="200" alt="Screenshot of home page">
<img src="screenshots/device-2020-06-05-085456.png" width="200" alt="Screenshot of a page with list of countries">
<img src="screenshots/device-2020-06-05-090524.png" width="200" alt="Screenshot of a page with a flag">
<img src="screenshots/device-2020-06-28-164528.png" width="300" alt="Screenshot of a home page with a bottom sheet">
<img src="screenshots/device-2020-10-18-103522.png" width="200" alt="Screenshot of a home page with the loading indicator">
<img src="screenshots/device-2020-10-18-103111.png" width="200" alt="Screenshot of a dialog">
<img src="screenshots/device-2020-06-05-090129.png" width="200" alt="Screenshot">
<img src="screenshots/device-2020-06-05-091508.png" width="200" alt="Screenshot of a page with my photo">
<img src="screenshots/device-2020-06-05-094730.png" width="300" alt="Screenshot of a tablet with the list of countries">
<img src="screenshots/device-2020-06-28-162902.png" width="400" alt="Screenshot of an info dialog">

**Code Readability:** code is easily readable with no unnecessary blank lines, no unused variables
or methods, and no commented-out code, all variables, methods, and resource IDs are descriptively
named such that another developer reading the code can easily understand their function.

## Download

<a href="https://play.google.com/store/apps/details?id=ua.turskyi.travelling" target="_blank">
<img src="https://play.google.com/intl/en_gb/badges/static/images/badges/en_badge_web_generic.png" width=240 alt="google play badge"/>
</a>
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ buildscript {
// Defining versions in a single place
ext {
// sdk versions
compile_sdk_version = 33
compile_sdk_version = 34
build_tools_version = "30.0.3"
min_sdk_version = 21
target_sdk_version = 33
target_sdk_version = 34
/* to check the latest version @see
https://play.google.com/console/u/0/developers/6867856033872987263/app/4975238491076611804/releases/overview
*/
Expand All @@ -22,7 +22,7 @@ https://play.google.com/console/u/0/developers/6867856033872987263/app/497523849
maven { url "https://jitpack.io" }
}
dependencies {
classpath 'com.android.tools.build:gradle:8.0.2'
classpath 'com.android.tools.build:gradle:8.1.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.7.20"
classpath "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"

Expand Down
2 changes: 1 addition & 1 deletion presentation/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ dependencies {
}
/* Declare the dependency for the Performance Monitoring library.
When using the BoM, we don't specify versions in Firebase library dependencies. */
implementation 'com.google.firebase:firebase-perf-ktx:20.3.2'
implementation 'com.google.firebase:firebase-perf-ktx:20.3.3'
implementation 'com.google.firebase:firebase-messaging:23.1.2'

// ViewModel and LiveData
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.google.gson.GsonBuilder
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.SupervisorJob
import okhttp3.Cache
import okhttp3.Interceptor
import okhttp3.OkHttpClient
import okhttp3.Request
import org.koin.android.ext.koin.androidContext
Expand Down Expand Up @@ -48,8 +49,6 @@ val interactorsModule = module {
factory { CountriesInteractor() }
}

// low (inner) level dependency injections

val repositoriesModule = module {
factory<CountriesRepository> { CountriesRepositoryImpl(CoroutineScope(SupervisorJob())) }
}
Expand All @@ -59,7 +58,7 @@ val dataProvidersModule = module {
single {
OkHttpClient.Builder()
.cache(get())
.addInterceptor { chain ->
.addInterceptor { chain: Interceptor.Chain ->
var request: Request = chain.request()
request = if (hasNetwork(androidContext())) {
request.newBuilder().header(
Expand Down

0 comments on commit 8fd369b

Please sign in to comment.