Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Steam API Extension #1876

Closed
wants to merge 15 commits into from
Closed

Add Steam API Extension #1876

wants to merge 15 commits into from

Conversation

xFN10x
Copy link

@xFN10x xFN10x commented Jan 19, 2025

the extension will have documentation soon, and ill add more blocks

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Jan 19, 2025
@xFN10x
Copy link
Author

xFN10x commented Jan 19, 2025

!format

@xFN10x
Copy link
Author

xFN10x commented Jan 19, 2025

!format

@xFN10x
Copy link
Author

xFN10x commented Jan 19, 2025

this is my first extension, so the code might be spaghetti

@SharkPool-SP
Copy link
Collaborator

this should just be added to the actual steam extension

@xFN10x
Copy link
Author

xFN10x commented Jan 20, 2025

this should just be added to the actual steam extension

I think as the steamworks extension as something you should have if you are putting your game on steam, this extension I feel, is mostly for playing around with the program

Copy link
Member

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go more indepth later

extensions/_FN10_/SteamAPI.js Show resolved Hide resolved
extensions/_FN10_/SteamAPI.js Outdated Show resolved Hide resolved
extensions/_FN10_/SteamAPI.js Outdated Show resolved Hide resolved
extensions/_FN10_/SteamAPI.js Outdated Show resolved Hide resolved
extensions/_FN10_/SteamAPI.js Outdated Show resolved Hide resolved
extensions/_FN10_/SteamAPI.js Show resolved Hide resolved
@GarboMuffin
Copy link
Member

If Steam does not let you directly access API without a CORS proxy then I'm not sure we can merge blocks that require an API key because it would inherently leak the API key to the CORS proxy. At least not without some design changes

@xFN10x
Copy link
Author

xFN10x commented Jan 20, 2025

ill remove api key blocks, unless we can found out how to make them more secure

@xFN10x
Copy link
Author

xFN10x commented Jan 20, 2025

I will combine these extensions into the "Steam Extension"

@xFN10x xFN10x closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants