Add EDR profiles to ESDLs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suvayu Apparently this repo is not very well protected if it's letting me merge without a review! 🤨 |
suvayu
approved these changes
Sep 9, 2024
Yes, because I'm the only committer in this repo. This is the first PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added profiles from EDR to ports of consumers (in-port) and some producers (out-port).
Not sure if this was the intention, since the original files didn't have profiles associated with assets.
The only one that DID have profiles was vehicle_charge_etc.esdl.
These are the new files:
The mesido and EYE files didn't really make sense for the application.
Also I'm not sure if the profiles I added will balance well in the system. (It's a bit unclear how Power/Energy and scaling with Multipliers work with the profiles.) Fingers crossed!
Closes #8