Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the InfluxDB client #23

Open
2 tasks
suvayu opened this issue Apr 18, 2024 · 3 comments
Open
2 tasks

Tests for the InfluxDB client #23

suvayu opened this issue Apr 18, 2024 · 3 comments
Assignees
Labels
Type: improvement Better way of doing something Zone: testing Related to improving or fixing the tests

Comments

@suvayu
Copy link
Member

suvayu commented Apr 18, 2024

... add a step in CI that starts an influxdb container with an endpoint and some data.

Originally posted by @suvayu in #19 (comment)

  • Implement a test that runs with EDR but is not included in CI
  • Implement a step in CI that spins up an InfluxDB instance, populates with dummy data, and runs the above test against this instance
@suvayu suvayu added Zone: testing Related to improving or fixing the tests Type: improvement Better way of doing something labels Apr 18, 2024
@clizbe
Copy link
Member

clizbe commented May 8, 2024

@wcoenraads Can you write these tests? :)

@wcoenraads
Copy link
Contributor

I can - but frankly, I think my time would be better spent elsewhere for now. These tests will be useful when we get more code relying on this functionality, and it would enable better testing then. But for now, these tests are quite a lot of work to create for what is literally 40 lines of simple code. So I would prefer to defer this work until it becomes more relevant.

@suvayu
Copy link
Member Author

suvayu commented May 13, 2024

@wcoenraads Do you think the first point is also a lot of effort? I would say if we can address the first one, and leave the more complete approach for later, it is a lot better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: improvement Better way of doing something Zone: testing Related to improving or fixing the tests
Projects
None yet
Development

No branches or pull requests

3 participants