WIP - DataFrames refactoring #612
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
===========================================
- Coverage 100.00% 99.05% -0.95%
===========================================
Files 15 15
Lines 639 633 -6
===========================================
- Hits 639 627 -12
- Misses 0 6 +6 ☔ View full report in Codecov by Sentry. |
abelsiqueira
force-pushed
the
611-construct-dataframes
branch
2 times, most recently
from
e43d70a
to
863f120
Compare
The function to create graph et al from a csv folder has been split into two functions. The first reads the csv folder into a new TableTree structure. The second processes the TableTree structure into graph et al.
Creates compute_constraints_partitions functions to use TableTree to build the partitions of the constraints. This is done in two parts. First, we create unrolled partitions, which will substitute the individual partitions vectors stores in the graphs. Second, we build constraints partitions still using compute_rp_partitions, but using only DataFrames. The result is also stored in a DataFrame, which should also serve as the final DataFrame to be used instead of energy_problem.dataframes.
abelsiqueira
force-pushed
the
611-construct-dataframes
branch
from
863f120
to
1ac6ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes made in this pull request
List of related issues or pull requests
Closes #ISSUE_NUMBER
Collaboration confirmation
As a contributor I confirm