Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_seasonal to define the base partitions #538

Closed
abelsiqueira opened this issue Mar 14, 2024 · 4 comments · Fixed by #543
Closed

Use is_seasonal to define the base partitions #538

abelsiqueira opened this issue Mar 14, 2024 · 4 comments · Fixed by #543
Assignees
Labels
Type: improvement Better way of doing something Zone: code architecture Changes to the structure or fundamentals Zone: data & import Interfacing between database and Julia

Comments

@abelsiqueira
Copy link
Member

What and Why

Instead of implicitly using the base-periods-partitions file.

Possible Drawbacks

We have to implement the implicit definition of the undeclared is_seasonal assets/flows to be :uniform,1, as we do with representative periods.

Related Issues

Blocked by #537

@abelsiqueira abelsiqueira added the Type: improvement Better way of doing something label Mar 14, 2024
@abelsiqueira abelsiqueira added Zone: code architecture Changes to the structure or fundamentals Zone: data & import Interfacing between database and Julia labels Mar 14, 2024
@abelsiqueira abelsiqueira self-assigned this Mar 14, 2024
@abelsiqueira
Copy link
Member Author

Related: #461

@abelsiqueira
Copy link
Member Author

Another drawback is that typos can lead to error behaviour, since this also introduces implicit behaviour. One possibility is to force both:

  • All is_seasonal need a entry in the partitions file
  • All entries in the partitions file have to be is_seasonal.

This can be implemented in this scope, but it is related to #461 as well. I recommend implement here now, since it doesn't hurt.

@datejada
Copy link
Member

The parameter is_seasonal should trigger the inter-rp constraints (defined on the base periods). I'm also thinking about issue #526, so:

  • if is_seasonal = false, no inter-rp constraints are created
  • if is_seasonal = true inter-rp constraints are created, the partition definitions will be read from the file.
  • if is_seasonal = true and there are no partition definitions, the default partition should be :uniform,1,

@abelsiqueira, does this description make it more clear?

@abelsiqueira
Copy link
Member Author

That's great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: improvement Better way of doing something Zone: code architecture Changes to the structure or fundamentals Zone: data & import Interfacing between database and Julia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants