I'm really sorry for the previous mistake, because this is the first time to use the pull request. #75
Conversation
There was a problem hiding this comment.
Don't worry about the previous attempt: we've all been beginners with git at some point ;)
I've just skimmed through quickly. All seems nice, but for now I have no clue about means to test it; could you tell me what new Python packages are needed, and a simple command to launch a GUI to perform a basic check? Also, I added a small comment below, which hints that a pull of TrustAI:master is needed (on a command line you may need to add this repository as a new remote, and then pull from it).
|
|
||
|
|
||
| class mnistclass: | ||
| def __init__(self, datasetName, modelFile): | ||
| def __init__(self,modelName): |
There was a problem hiding this comment.
This change reverts some recent changes to the master branch. This is a hint that you need to pull the master branch before creating the pull request: you may then be asked by git to merge those more recent changes to the master branch into your own changes (if you're lucky this will be automated and you won't have to do anything manually).
There was a problem hiding this comment.
PyQt5 and runipy is needed. you can install them by command below:
pip install PyQt5
pip install runipy
and launch the GUI by command below:
runipy GUI.ipynb
There was a problem hiding this comment.
Thanks for the dependencies and commands. Note I encountered many issues in trying to use runipy, and found out it is quite an out-dated tool. So I ended up searching a bit for alternatives, and used jupyter with the command below:
jupyter nbconvert --to python GUI.ipynb --stdout | python3(I don't know what Python package the jupyter command comes from. I just happened to have it installed already.)
So I managed to run it all as it is.
However, some changes introduced in commit 3be0484 reverts some recent changes. I think cleaning that up properly requires rebasing on your own side. Although, to keep the process simple enough, you may be able to revert it manually with git show 3be04847c08cf | git apply -R, and then you commit only the changes you did not do yourself (with git commit -p). After that you git stash (which should put your own modifications back in place), and you shall be able to test that the tool still works.
If that's too intricate, just tell me; I should be able to do this on my side at some point (I did most or all of the changes in master that we need to re-introduce).
No description provided.