Add proxy middleware #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@navidboloorian Can you describe what you did to test this before I merge it? |
Never mind, I implemented a fix which I think is more likely to work across systems. Test it yourself when you review. |
wllmwu
commented
Nov 3, 2023
Comment on lines
-117
to
+124
| const response = await fetchRequest("GET", url, body, headers); | ||
| const response = await fetchRequest("PUT", API_BASE_URL + url, body, headers); |
There was a problem hiding this comment.
@navidboloorian This was a little sloppy tbh, I should have looked more closely when reviewing
navidboloorian
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What changes did you make? Include screenshots if applicable, or explain how to view the changes.
Fix "Invalid options object" error onnpm startby usinghttp-proxy-middlewarepackage instead ofproxyline inpackage.jsonproxyline fromfrontend/package.jsonTesting
How did you confirm your changes work? (Automated tests, manual verification, etc.)
Not sure how this has been tested -@wllmwuTracking
Add your issue number below.
No issue was created for this bug, see Changes above