Implemented fallback checking for creature_template_difficulty entries

WowPacketParser/SQL/SQLDatabase.cs

@@ -29,6 +29,7 @@ public static class SQLDatabase
         public static Dictionary<uint /*broadcastText*/, List<uint> /*npc_text ids*/> BroadcastToNPCTexts { get; } = new();
         public static Dictionary<int /*menuID*/, List<uint> /*npc_text ids*/> GossipMenuToNPCTexts { get; } = new();
         public static Dictionary<int /*worldStateID*/, string> WorldStateNames { get; } = new();
+        public static Dictionary<(uint /*CreatureId*/, uint /*DifficultyID*/), CreatureTemplateDifficultyWDB> CreatureTemplateDifficultyWDBData = new();
         public static List<POIData> POIs { get; } = new List<POIData>();
 
         private static readonly StoreNameType[] ObjectTypes =
@@ -109,6 +110,7 @@ public static void LoadSQL()
             LoadBroadcastText();
             LoadPointsOfinterest();
             LoadCreatureEquipment();
+            LoadCreatureTemplateDifficultyWDBData();
             LoadNPCTexts();
             LoadGossipMenuNPCTexts();
             LoadWorldStates();
@@ -285,6 +287,70 @@ private static void LoadCreatureEquipment()
             }
         }
 
+        private static void LoadCreatureTemplateDifficultyWDBData()
+        {
+            if (Settings.TargetedDatabase < TargetedDatabase.Dragonflight || !Settings.DBEnabled)
+                return;
+
+            string columns = "Entry, DifficultyID, HealthScalingExpansion, HealthModifier, ManaModifier, CreatureDifficultyID, TypeFlags, TypeFlags2";
+            string query = $"SELECT {columns} FROM {Settings.TDBDatabase}.creature_template_difficulty";
+
+            using (var command = SQLConnector.CreateCommand(query))
+            {
+                if (command == null)
+                    return;
+                using (MySqlDataReader reader = command.ExecuteReader())
+                {
+                    while (reader.Read())
+                    {
+                        var data = new CreatureTemplateDifficultyWDB
+                        {
+                            Entry = reader.GetUInt32("Entry"),
+                            DifficultyID = reader.GetUInt32("DifficultyID"),
+                            HealthScalingExpansion = (ClientType)reader.GetInt32("HealthScalingExpansion"),
+                            HealthModifier = reader.GetFloat("HealthModifier"),
+                            ManaModifier = reader.GetFloat("ManaModifier"),
+                            CreatureDifficultyID = reader.GetInt32("CreatureDifficultyID"),
+                            TypeFlags = (CreatureTypeFlag)reader.GetUInt32("TypeFlags"),
+                            TypeFlags2 = reader.GetUInt32("TypeFlags2")
+                        };
+                        CreatureTemplateDifficultyWDBData.Add((data.Entry.Value, data.DifficultyID.Value), data);
+                    }
+                }
+            }
+        }
+
+        public static CreatureTemplateDifficultyWDB CheckCreatureTemplateDifficultyWDBFallbacks(CreatureTemplateDifficultyWDB sniffData, uint difficulty)
+        {
+            // if db disabled/empty simply return sniff data
+            if (CreatureTemplateDifficultyWDBData.Count == 0)
+                return sniffData;
+
+            // entry with same difficulty already exists
+            if (CreatureTemplateDifficultyWDBData.TryGetValue((sniffData.Entry.Value, difficulty), out var dbData))
+            {
+                // data is equal, return sniffData to update
+                if (sniffData.WDBEqualsSkipDifficultySkipHealthScalingExpansion(dbData))
+                {
+                    sniffData.DifficultyID = dbData.DifficultyID;
+                    return sniffData;
+                }
+
+                // data is not equal, insert new row
+                return sniffData;
+            }
+            // entry with same difficulty does not exist, check fallback difficulties recursively
+            else
+            {
+                if (!Settings.UseDBC || DBC.DBC.Difficulty == null)
+                    return sniffData;
+
+                if (DBC.DBC.Difficulty.TryGetValue((int)difficulty, out var difficultyEntry))
+                    return CheckCreatureTemplateDifficultyWDBFallbacks(sniffData, difficultyEntry.FallbackDifficultyID);
+            }
+            return sniffData;
+        }
+
         private static void LoadNPCTexts()
         {
             if (Settings.TargetedDatabase == TargetedDatabase.TheBurningCrusade)

WowPacketParser/Store/Objects/CreatureTemplateDifficulty.cs

@@ -1,3 +1,4 @@
+using System;
 using WowPacketParser.Enums;
 using WowPacketParser.Misc;
 using WowPacketParser.SQL;
@@ -31,6 +32,19 @@ public sealed record CreatureTemplateDifficultyWDB : IDataModel
 
         [DBFieldName("TypeFlags2", TargetedDatabaseFlag.SinceDragonflight | TargetedDatabaseFlag.WotlkClassic)]
         public uint? TypeFlags2;
+
+        public bool WDBEqualsSkipDifficultySkipHealthScalingExpansion(CreatureTemplateDifficultyWDB rhs)
+        {
+            if (rhs == null)
+                return false;
+
+            return Entry == rhs.Entry &&
+                Math.Abs(HealthModifier.Value - rhs.HealthModifier.Value) < 0.01f &&
+                Math.Abs(ManaModifier.Value - rhs.ManaModifier.Value) < 0.01f &&
+                CreatureDifficultyID == rhs.CreatureDifficultyID &&
+                TypeFlags == rhs.TypeFlags &&
+                TypeFlags2 == rhs.TypeFlags2;
+        }
     }
 
     [DBTableName("creature_template_scaling", TargetedDatabaseFlag.TillShadowlands)]

WowPacketParserModule.V7_0_3_22248/Parsers/CreatureHandler.cs

@@ -144,6 +144,7 @@ public static void HandleCreatureQueryResponse(Packet packet)
                 TypeFlags = creature.TypeFlags,
                 TypeFlags2 = creature.TypeFlags2
             };
+            creatureTemplateDifficultyWDB = WowPacketParser.SQL.SQLDatabase.CheckCreatureTemplateDifficultyWDBFallbacks(creatureTemplateDifficultyWDB, creatureTemplateDifficultyWDB.DifficultyID.Value);
             Storage.CreatureTemplateDifficultiesWDB.Add(creatureTemplateDifficultyWDB);
 
             ObjectName objectName = new ObjectName

WowPacketParserModule.V8_0_1_27101/Parsers/CreatureHandler.cs

@@ -166,6 +166,7 @@ public static void HandleCreatureQueryResponse(Packet packet)
                 TypeFlags = creature.TypeFlags,
                 TypeFlags2 = creature.TypeFlags2
             };
+            creatureTemplateDifficultyWDB = WowPacketParser.SQL.SQLDatabase.CheckCreatureTemplateDifficultyWDBFallbacks(creatureTemplateDifficultyWDB, creatureTemplateDifficultyWDB.DifficultyID.Value);
             Storage.CreatureTemplateDifficultiesWDB.Add(creatureTemplateDifficultyWDB);
 
             ObjectName objectName = new ObjectName

WowPacketParserModule.V9_0_1_36216/Parsers/CreatureHandler.cs

@@ -178,6 +178,7 @@ public static void HandleCreatureQueryResponse(Packet packet)
                 TypeFlags = creature.TypeFlags,
                 TypeFlags2 = creature.TypeFlags2
             };
+            creatureTemplateDifficultyWDB = WowPacketParser.SQL.SQLDatabase.CheckCreatureTemplateDifficultyWDBFallbacks(creatureTemplateDifficultyWDB, creatureTemplateDifficultyWDB.DifficultyID.Value);
             Storage.CreatureTemplateDifficultiesWDB.Add(creatureTemplateDifficultyWDB);
 
             ObjectName objectName = new ObjectName