-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LILA-6854] Address Team Omega comments, update emails and versions #56
Conversation
0xmichalis
commented
Jun 10, 2024
•
edited
Loading
edited
- Address feedback from https://github.com/OmegaAudits/toucan-dynamic-fee-pools/pull/2
- Update security emails
- Bump versions
- Optimize zero amount checks
Already checked by _calculateFee.
there's no reason to check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have 1 comment that wasn't in the audit, other than that lgtm
This is true for all uint256 > 0 checks in the contracts. Updated |
@@ -2,7 +2,7 @@ | |||
// | |||
// SPDX-License-Identifier: UNLICENSED | |||
|
|||
// If you encounter a vulnerability or an issue, please contact <info@neutralx.com> | |||
// If you encounter a vulnerability or an issue, please contact <security@toucan.earth> or visit security.toucan.earth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://security.toucan.earth/ would be better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retro +1